🌱 Update the Task TypeScript interface
#1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the `Task` interface, and related, to follow the current definitions of Task REST resource[1] on the hub. Supports: konveyor#1955, konveyor#1956, konveyor#1957 [1] - https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748 Signed-off-by: Scott J Dickerson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1961 +/- ##
==========================================
+ Coverage 39.20% 42.13% +2.93%
==========================================
Files 146 166 +20
Lines 4857 5328 +471
Branches 1164 1294 +130
==========================================
+ Hits 1904 2245 +341
- Misses 2939 3067 +128
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rszwajko
reviewed
Jun 14, 2024
client/src/app/api/models.ts
Outdated
Comment on lines
362
to
366
| export interface Attachment { | ||
| id: number; | ||
| name?: string; | ||
| activity?: number; | ||
| } |
There was a problem hiding this comment.
I'd rather keep "Task" prefix like in https://github.com/rszwajko/tackle2-ui/blob/e4b6895a65310d95edbb186472623c533045973d/client/src/app/api/models.ts#L325
Signed-off-by: Scott J Dickerson <[email protected]>
rszwajko
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
Taskinterface, and related, to follow the current definitions of Task REST resource1 on the hub.Supports: #1955, #1956, #1957
Footnotes
https://github.com/konveyor/tackle2-hub/blob/1366d95b62ac7717826fd9f64c9e268013107008/api/task.go#L725-L748 ↩