✨ Update business services table to use ActionsColumn

[mguetta1]

Related to #1318

OR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.05%. Comparing base (b654645) to head (a034768).
Report is 172 commits behind head on main.

❗ Current head a034768 differs from pull request most recent head 8d03157

Please upload reports for the commit 8d03157 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1921      +/-   ##
==========================================
+ Coverage   39.20%   42.05%   +2.85%     
==========================================
  Files         146      166      +20     
  Lines        4857     5340     +483     
  Branches     1164     1298     +134     
==========================================
+ Hits         1904     2246     +342     
- Misses       2939     3078     +139     
- Partials       14       16       +2     

Flag	Coverage Δ
client	42.05% <ø> (+2.85%)	⬆️
server	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sjd78]

LGTM, I just want to check on the edit pencil icon in some other tables

[sjd78]

LGTM

[sjd78]

@mguetta1 - I like the one with the edit pencil. Which option do you want to use?

[rszwajko]

@mguetta1 @ibolton336
AppTableActionButtons is a wrapper that provides RBAC access check. Please provide some more context why we need to remove it.

[ibolton336]

@mguetta1 @ibolton336 AppTableActionButtons is a wrapper that provides RBAC access check. Please provide some more context why we need to remove it.

The idea initially was to standardize on a common approach in the table now that this new table component was available. Modifying the AppTableActionButtons component to make use of the ActionsColumn may be a better approach. The use of PF Flex inside the AppTableActionButtons causes some inconsistent spacing when compared to the tables using ActionsColumn.

[sjd78]

@mguetta1 @ibolton336 AppTableActionButtons is a wrapper that provides RBAC access check. Please provide some more context why we need to remove it.

The idea initially was to standardize on a common approach in the table now that this new table component was available. Modifying the AppTableActionButtons component to make use of the ActionsColumn may be a better approach. The use of PF Flex inside the AppTableActionButtons causes some inconsistent spacing when compared to the tables using ActionsColumn.

Structurally I like the "new" style for the component layout. However, with the different containing component, are we dropping some RBAC checks? That could be ok so long as there is a new effort soon (i.e. in the release after 0.5) to refactor RBAC and apply it on all actions. Humm, I may need to write up an issue to capture that work (and keycloak lib upgrades).

[mguetta1]

@mguetta1 - I like the one with the edit pencil. Which option do you want to use?

This option

[mguetta1]

@rszwajko @ibolton336 @sjd78
I don't think that there is any permission restrictions on controls. Anyway I added the controlsWriteScopes to the business service create button
69ff6b2

[ibolton336]

@rszwajko @ibolton336 @sjd78 I don't think that there is any permission restrictions on controls. Anyway I added the controlsWriteScopes to the business service create button 69ff6b2

I think it'd be worth trying to save the component for reuse as Radek mentioned. That way we don't need a new PR for each place we make these changes & can avoid maintenance headaches.

[mguetta1]

bs-new.mp4

[sjd78]

This looks good. I'd just like to see the new component in a different folder.

[sjd78]

LGTM

Concerns addressed