Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Business services table update #1116

Merged
merged 3 commits into from
Jun 25, 2024
Merged

[RFR] Business services table update #1116

merged 3 commits into from
Jun 25, 2024

Conversation

mguetta1
Copy link
Contributor

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mguetta1 mguetta1 changed the title Business services table update [RFR] Business services table update May 27, 2024
@mguetta1 mguetta1 requested a review from sshveta May 27, 2024 11:48
@mguetta1 mguetta1 marked this pull request as ready for review June 21, 2024 08:46
ibragins
ibragins approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@ibragins ibragins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mguetta1 mguetta1 requested a review from abrugaro June 25, 2024 09:37
abrugaro
abrugaro requested changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, apart from that, the jenkins job failed, could you please take a look and provide a new one?

ThankS!

cypress/e2e/tests/migration/controls/businessservices/create.test.ts Outdated Show resolved Hide resolved
@mguetta1 mguetta1 force-pushed the business-services-table branch 4 times, most recently from 5dfac30 to 1592289 Compare June 25, 2024 12:11
abrugaro
abrugaro approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@abrugaro abrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibragins ibragins merged commit 5b5c371 into konveyor:main Jun 25, 2024
7 checks passed
@mguetta1 mguetta1 deleted the business-services-table branch June 26, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshveta sshveta sshveta left review comments

@abrugaro abrugaro abrugaro approved these changes

@ibragins ibragins Awaiting requested review from ibragins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mguetta1 @sshveta @ibragins @abrugaro