-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👻 Update check for running analysis / cancel analysis #1885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks ok with the regex, just a suggestion about how it could be done differently.
client/src/app/pages/applications/applications-table/applications-table.tsx
Outdated
Show resolved
Hide resolved
client/src/app/pages/applications/applications-table/applications-table.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
+ Coverage 39.20% 42.22% +3.01%
==========================================
Files 146 170 +24
Lines 4857 5450 +593
Branches 1164 1363 +199
==========================================
+ Hits 1904 2301 +397
- Misses 2939 3133 +194
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b80fc70
to
382d705
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checks read a bunch better now with the .includes()
in place of the regex.
Is this PR dependent on a hub PR getting merged? If yes, please reference the PR or hub issue in the PR description. |
Description updated with more context! Could not find a specific hub PR for this. @sjd78 |
@ibolton336
|
Signed-off-by: Ian Bolton <[email protected]>
cd8eaf7
to
c9209ef
Compare
This PR narrows down the check for analysis tasks that are cancellable. Also the logic is updated and flipped for "disabling" the creation of a new analysis task. Analysis tasks should be creatable when there are no states for tasks outside of "succeeded" or "failed". This will future proof against any other additional task states that may be added in the future. The "scheduled" state was just added for 0.4 & is the motivation behind this PR ( as requested by @jortel )