Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Analysis button on application table remains disabled after starting 1 analysis #1976

Closed
1 task done
sjd78 opened this issue Jun 21, 2024 · 2 comments · Fixed by #1977
Closed
1 task done

[BUG] Analysis button on application table remains disabled after starting 1 analysis #1976

sjd78 opened this issue Jun 21, 2024 · 2 comments · Fixed by #1977
Assignees
@sjd78
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone
v0.5.0

Comments

@sjd78
Copy link
Member

sjd78 commented Jun 21, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

main

Priority

Critical

Current Behavior

  • Start an analysis for an application (single selection on just app A)
  • Attempt to start an analysis for another application (single selection on just app B)
  • Analysis button is not enabled

Expected Behavior

When selecting an application(s) with no currently running analysis task, the analysis button should be enabled.

How Reproducible

Always (Default)

Steps To Reproduce

No response

Environment

- OS:

Anything else?

No response
@sjd78 sjd78 added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 21, 2024
@sjd78 sjd78 added this to Planning Jun 21, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jun 21, 2024
@sjd78 sjd78 self-assigned this Jun 21, 2024
@sjd78 sjd78 moved this from 🆕 New to 🏗 In progress in Planning Jun 21, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@sjd78 sjd78 added this to the v0.5.0 milestone Jun 21, 2024
@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Jun 21, 2024
@sjd78 sjd78 added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jun 21, 2024
@sjd78
Copy link
Member Author

sjd78 commented Jun 21, 2024

Appears to be a regression related to #1885

sjd78 added a commit to sjd78/tackle2-ui that referenced this issue Jun 21, 2024
@sjd78
🐛 Update the enabled check for the Analysis button
122aab7 
On the application table, update the analysis button's
enable/disable check such that analysis is only allowed
to be started when all of the selected applications do
not have a current in-flight task running.

Resolves: konveyor#1976

Signed-off-by: Scott J Dickerson <[email protected]>
@sjd78 sjd78 mentioned this issue Jun 21, 2024
Merged
@sjd78 sjd78 closed this as completed in 172710a Jun 21, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sjd78 sjd78

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/major Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Planning
Status: ✅ Done
Milestone
v0.5.0
Development

Successfully merging a pull request may close this issue.

🐛 Update the enabled check for the Analysis button sjd78/tackle2-ui
1 participant
@sjd78