🐛 Update the enabled check for the Analysis button #1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the application table, update the analysis button's enable/disable check such that analysis is only allowed to be started when all of the selected applications do not have a current in-flight task running. Resolves: konveyor#1976 Signed-off-by: Scott J Dickerson <[email protected]>
ibolton336
previously approved these changes
Jun 21, 2024
rszwajko
reviewed
Jun 21, 2024
client/src/app/pages/applications/applications-table/applications-table.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Scott J Dickerson <[email protected]>
Signed-off-by: Scott J Dickerson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
==========================================
+ Coverage 39.20% 42.22% +3.01%
==========================================
Files 146 170 +24
Lines 4857 5450 +593
Branches 1164 1325 +161
==========================================
+ Hits 1904 2301 +397
- Misses 2939 3133 +194
- Partials 14 16 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Screen ShotsAnalysis button enabled when the selected app doesn't have a task: Analysis button disabled when one of the selected apps has a queued task: Analysis button enabled when selected an app whose previous task is complete: |
ibolton336
approved these changes
Jun 21, 2024
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the application table, update the analysis button's enable/disable check such that analysis is only allowed to be started when all of the tasks for the selected applications are in a terminal state (they are not in-flight/queued).
Fixes: #1976