Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open edit/preview Enketo Express links with KPI as OpenRosa server #3689

Merged
merged 20 commits into from
Feb 22, 2022
Merged

Open edit/preview Enketo Express links with KPI as OpenRosa server #3689

merged 20 commits into from
Feb 22, 2022

Conversation

noliveleger
Copy link
Contributor

@noliveleger noliveleger commented Feb 16, 2022 •
edited
Loading

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a description of your work suitable for publishing on our forum
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. [] Open an issue in the docs if there are UI/UX changes

Description

Get Enketo Express preview and edit links through KPI directly. Add an OpenRosa server to let Enketo Express submit submissions on edit.

Related issues

Closes #3654
Blocked by kobotoolbox/kobocat#791

@noliveleger noliveleger mentioned this pull request Feb 16, 2022
Closed
7 tasks
@noliveleger noliveleger changed the title WIP - Edit with openrosa server WIP - Open edit/preview Enketo Express links with KPI as OpenRosa server Feb 16, 2022
@noliveleger noliveleger requested a review from jnm February 18, 2022 22:43
@noliveleger noliveleger marked this pull request as ready for review February 18, 2022 22:46
@noliveleger noliveleger changed the title WIP - Open edit/preview Enketo Express links with KPI as OpenRosa server Open edit/preview Enketo Express links with KPI as OpenRosa server Feb 18, 2022
jnm
jnm requested changes Feb 21, 2022
View reviewed changes
kobo/apps/reports/report_data.py Show resolved Hide resolved
kobo/apps/reports/report_data.py Show resolved Hide resolved
kpi/authentication.py Show resolved Hide resolved
kpi/deployment_backends/base_backend.py Outdated Show resolved Hide resolved
kpi/deployment_backends/kobocat_backend.py Outdated Show resolved Hide resolved
kpi/views/v2/asset_snapshot.py Outdated Show resolved Hide resolved
kpi/views/v2/data.py Show resolved Hide resolved
kpi/views/v2/data.py Show resolved Hide resolved
kpi/views/v2/data.py Outdated Show resolved Hide resolved
kpi/views/v2/data.py Outdated Show resolved Hide resolved
@jnm
Copy link
Member

jnm commented Feb 21, 2022 •
edited
Loading

scenarios to test:

  • manually specified form_title ✔️
  • manually specified name (in XLSForm, i.e. the XML root node name) ✔️
    • seems we don't actually honor name in the settings of uploaded XLSForm, but submission XML with arbitrary root node names do work properly

auth necessary to read from snapshots? (yes, uses session auth / kobonaut cookie ✔️)

@jnm jnm mentioned this pull request Feb 21, 2022
Open
jnm added 2 commits February 22, 2022 11:41
@jnm
Merge pull request #3693 from kobotoolbox/edit-with-openrosa-server__…
74c66d4 
…proposed-changes

Make changes discussed during review of #3689
@jnm
Revert "Revert code style changes temporarily"
a8a7930 
This reverts commit 9141009.
@jnm jnm merged commit 07ec8dc into beta Feb 22, 2022
@jnm jnm deleted the edit-with-openrosa-server branch February 22, 2022 17:49
@jnm jnm mentioned this pull request Mar 2, 2022
Merged
This was referenced Mar 21, 2022
Merged
Open
@jnm jnm mentioned this pull request Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm jnm jnm requested changes

Assignees

@jnm jnm

Labels
Back end blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noliveleger @jnm