Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission "edit" only loads latest version version of form #3736

Open
esmail opened this issue Oct 24, 2016 · 3 comments
Open

Submission "edit" only loads latest version version of form #3736

esmail opened this issue Oct 24, 2016 · 3 comments

Comments

@esmail
Copy link

esmail commented Oct 24, 2016

No description provided.

@jnm
Copy link
Member

jnm commented May 19, 2021

This is well described in https://github.com/enketo/enketo-express/issues/253 and probably should be moved to KPI, especially now that we have enough OpenRosa stuff there now to serve up form previews: #2487 (comment)

@jnm jnm transferred this issue from kobotoolbox/kobocat Mar 21, 2022
@jnm
Copy link
Member

jnm commented Mar 21, 2022

We fixed it in #3689, we un-fixed it in #3734, and we'll fix it again once we have a UI to let people decide which version they want to use when editing. I think the only choices will be the latest version of the form and the version in effect when the submission was created.

@jnm
Copy link
Member

jnm commented Apr 1, 2022

When we fix this again, we need to take into account that pyxform may have added new checks (for example, forbidding duplicate choice names) since people deployed their forms. We may need to disable these checks for internal JSON->XLSForm->XForm conversions. Hopefully we can avoid having to store a copy of the XForm XML alongside the AssetVersion JSON to safeguard ourselves from changes in pyxform behavior.

See also internal discussion: https://chat.kobotoolbox.org/#narrow/stream/6-Support/topic/Issues.20with.20submission.20edits/near/98844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants