Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict supported service types of Karamda APIServer supported by karmada-operator #5769

Merged
merged 1 commit into from
Nov 2, 2024
+24 −8
Merged

Restrict supported service types of Karamda APIServer supported by karmada-operator #5769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions charts/karmada-operator/crds/operator.karmada.io_karmadas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2539,9 +2539,15 @@ spec:
Defaults to "10.96.0.0/12".
type: string
serviceType:
description: |-
ServiceType represents the service type of karmada apiserver.
it is ClusterIP by default.
default: ClusterIP
description: |-
ServiceType represents the service type of Karmada API server.
Valid options are: "ClusterIP", "NodePort", "LoadBalancer".
Defaults to "ClusterIP".
enum:
- ClusterIP
- NodePort
- LoadBalancer
type: string
type: object
karmadaAggregatedAPIServer:
Expand Down
12 changes: 9 additions & 3 deletions operator/config/crds/operator.karmada.io_karmadas.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2539,9 +2539,15 @@ spec:
Defaults to "10.96.0.0/12".
type: string
serviceType:
description: |-
ServiceType represents the service type of karmada apiserver.
it is ClusterIP by default.
default: ClusterIP
description: |-
ServiceType represents the service type of Karmada API server.
Valid options are: "ClusterIP", "NodePort", "LoadBalancer".
Defaults to "ClusterIP".
enum:
- ClusterIP
- NodePort
- LoadBalancer
type: string
type: object
karmadaAggregatedAPIServer:
Expand Down
8 changes: 6 additions & 2 deletions operator/pkg/apis/operator/v1alpha1/type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,12 @@ type KarmadaAPIServer struct {
// +optional
ServiceSubnet *string `json:"serviceSubnet,omitempty"`

// ServiceType represents the service type of karmada apiserver.
// it is ClusterIP by default.
// ServiceType represents the service type of Karmada API server.
// Valid options are: "ClusterIP", "NodePort", "LoadBalancer".
// Defaults to "ClusterIP".
//
// +kubebuilder:default="ClusterIP"
// +kubebuilder:validation:Enum=ClusterIP;NodePort;LoadBalancer
// +optional
ServiceType corev1.ServiceType `json:"serviceType,omitempty"`

Expand Down