Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict supported service types of Karamda APIServer supported by karmada-operator #5769

Conversation

RainbowMango
Copy link
Member

@RainbowMango RainbowMango commented Nov 1, 2024

What type of PR is this?

/kind cleanup
/kind api-change

What this PR does / why we need it:
This PR restrics the service types supported by karmada-operator.

Which issue(s) this PR fixes:
Part of #5767

Special notes for your reviewer:
This PR introduces validation rules which narrow down the range of acceptable configuration, but this has no impact on users who are currently using ClusterIP and NodePort. And for Loadbalancer and ExternalName, currently not supported. (We are considering introduce the support of Loadbalancer to address the use case reported at #4634).

Does this PR introduce a user-facing change?:

The ServiceType of the Karmada API server in `Karmada` API now has been restricted to `ClusterIP`, `NodePort`, and `LoadBalancer`.

@karmada-bot karmada-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Nov 1, 2024
@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 1, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.32%. Comparing base (057cf86) to head (a644477).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5769      +/-   ##
==========================================
+ Coverage   42.31%   42.32%   +0.01%     
==========================================
  Files         655      655              
  Lines       55756    55756              
==========================================
+ Hits        23591    23598       +7     
+ Misses      30651    30646       -5     
+ Partials     1514     1512       -2     
Flag Coverage Δ
unittests 42.32% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainbowMango
Copy link
Member Author

@chaosi-zju
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2024
@RainbowMango RainbowMango added this to the v1.12 milestone Nov 2, 2024
@RainbowMango RainbowMango added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot merged commit b270d02 into karmada-io:master Nov 2, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants