add workflow for Agenda Verification and Notifications before Monday Meetings #802

nikhilkalburgi · 2024-09-16T13:13:58Z

GitHub Issue: #794

Summary:

I have created a workflow that checks if the issue contains the original template every Monday 10min before the meeting. If there is any agenda added to it by the issue-collector workflow, then the condition does not match else a comment is sent to the issue thread along with slack notification like it is done for few other workflows.

This does not close the issue itself. Let me know if this works and you also want me to automate closing the issue.

benjagm

Thanks a lot for this PR! Much appreciated. I just added a few suggestions but looks great ...

benjagm · 2024-09-19T14:21:23Z

.github/workflows/ocwm-pre-meeting-check.yml

+        REPO: 'community'
+        OCWM_LABEL: ${{ vars.OCWM_LABEL }}
+        TEMPLATE_PATH: '../ISSUE_TEMPLATE/open_community_working_meeting.md'
+        SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}


Suggested change

SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}

SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_GEN_NOTIF }}

This is the secret containing the the webhook

benjagm · 2024-09-19T14:29:01Z

.github/workflows/ocwm-pre-meeting-check.yml

+
+on:
+  schedule:
+    - cron: '50 21 * * 1'  # Runs at 21:50 UTC, which is 10 minutes before 14:00 PT every Monday


Suggested change

- cron: '50 21 * * 1' # Runs at 21:50 UTC, which is 10 minutes before 14:00 PT every Monday

- cron: '50 18 15-21 * 1' # Runs at 11:50 AM PT on the 3rd Monday of the month

I am suggesting this change because we just decided to make the meetings mothly the 3rd monday of the month and 2 hours earlier as 12:00 PT

benjagm · 2024-09-19T14:32:16Z

.github/workflows/ocwm-pre-meeting-check.yml

+
+          // Add a comment to the issue
+          await mygithub.request(`POST /repos/${process.env.OWNER}/${process.env.REPO}/issues/${latestIssue.number}/comments`, {
+            body: "The meeting as been cancelled as there is no agenda for today. Thanks"


Suggested change

body: "The meeting as been cancelled as there is no agenda for today. Thanks"

body: "The meeting has been cancelled as there is no agenda for today. Thanks everyone!"

benjagm · 2024-09-19T14:32:31Z

.github/workflows/ocwm-pre-meeting-check.yml

+
+          // Send a notification to Slack
+          const slackPayload = {
+            text: `The meeting as been cancelled as there is no agenda for today. Thanks`


Suggested change

text: `The meeting as been cancelled as there is no agenda for today. Thanks`

text: `The meeting has been cancelled as there is no agenda for today. Thanks everyone!`

nikhilkalburgi · 2024-09-20T10:16:47Z

Hi @benjagm,

I've made the changes that were suggested to the workflow.

benjagm

Hi @nikhilkalburgi. I added some more suggestions mostly I found that making the process run only on the third monday of the month is not as easy as I thought and is not possible using only using cron. Please check the code and let me know.

benjagm · 2024-09-23T09:13:56Z

.github/workflows/ocwm-pre-meeting-check.yml

+
+on:
+  schedule:
+    - cron: '50 18 15-21 * 1'  # Runs at 11:50 AM PT on the 3rd Monday of the month


Suggested change

- cron: '50 18 15-21 * 1' # Runs at 11:50 AM PT on the 3rd Monday of the month

- cron: '50 21 * * 1' # Runs at 21:50 UTC, which is 10 minutes before 14:00 PT every Monday

My apologies but the code I suggested to be added was not working as I was expecting so sorry for suggesting it. Let's return your previous change.

Make the process runs only the third monday is not possible only using cron. We'll need to add a new step the workflow. I'll suggest the change later.

benjagm · 2024-09-23T09:15:36Z

.github/workflows/ocwm-pre-meeting-check.yml

+
+    - name: Install Dependencies
+      run: npm install @octokit/[email protected]
+


Suggested change

# Step to check if today is the third Monday

- name: Check if today is the third Monday

id: check-third-monday

run: |

day=$(date +%d)

dow=$(date +%u) # Day of the week (1 = Monday, ..., 7 = Sunday)

# Check if the day is between 15th and 21st, and if it's Monday (1)

if [ "$dow" -ne 1 ]; then

echo "Not a Monday, exiting..."

exit 0

fi

if [ "$day" -ge 15 ] && [ "$day" -le 21 ]; then

echo "This is the third Monday of the month!"

else

echo "Not the third Monday, exiting..."

exit 0

fi

This new step will make sure the process only runs completely the third monday of the month.

nikhilkalburgi · 2024-09-23T14:08:03Z

Hi @benjagm ,

I have added the new step to the workflow. I had to do tests to check if the last step is working. Anyway..Let me know if any other changes are required here.

gregsdennis · 2024-09-23T18:17:13Z

Can you rename this PR, please? 'Resolves an issue' doesn't tell me what this PR does.

nikhilkalburgi · 2024-09-24T09:05:28Z

Can you rename this PR, please? 'Resolves an issue' doesn't tell me what this PR does.

Renaming Done!

We are facing issues with this same logic in other workflows. I am just applying the same version we have in other workflows to consistently merge with master branch.

benjagm

Huge thanks for this contribution!! Let's merge it!

nikhilkalburgi added 2 commits September 16, 2024 18:27

Add ocwm-pre-meeting-check.yml to workflow

e0f0778

change ocwm-pre-meeting-check.yml comment

302a673

benjagm requested changes Sep 19, 2024

View reviewed changes

fix: update ocwm-pre-meeting-check.yml with suggested changes

f8948ce

benjagm requested changes Sep 23, 2024

View reviewed changes

nikhilkalburgi added 16 commits September 23, 2024 18:31

update ocwm-pre-meeting-check.yml

c295acf

update ocwm-pre-meeting-check.yml for test

50942a3

second update ocwm-pre-meeting-check.yml for test

56383f9

third update ocwm-pre-meeting-check.yml for test

4bd44db

forth update ocwm-pre-meeting-check.yml for test

6fff2ca

Update ocwm-pre-meeting-check.yml

9323d93

Update ocwm-pre-meeting-check.yml

05f72a1

Update ocwm-pre-meeting-check.yml

638acae

Update ocwm-pre-meeting-check.yml

e6928b3

Update ocwm-pre-meeting-check.yml

495c6f9

Update ocwm-pre-meeting-check.yml

e091bae

Update ocwm-pre-meeting-check.yml

6299e1a

Update ocwm-pre-meeting-check.yml

ef9ffbe

Update ocwm-pre-meeting-check.yml

86bf421

Update ocwm-pre-meeting-check.yml

d568f57

fix: improve ocwm-pre-meeting-check.yml

7e93929

nikhilkalburgi changed the title ~~resolves #794~~ add workflow for Agenda Verification and Notifications before Monday Meetings Sep 24, 2024

Update ocwm-pre-meeting-check.yml

93cc7e1

We are facing issues with this same logic in other workflows. I am just applying the same version we have in other workflows to consistently merge with master branch.

benjagm approved these changes Sep 24, 2024

View reviewed changes

benjagm merged commit defef76 into json-schema-org:main Sep 24, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add workflow for Agenda Verification and Notifications before Monday Meetings #802

add workflow for Agenda Verification and Notifications before Monday Meetings #802

nikhilkalburgi commented Sep 16, 2024

benjagm left a comment

benjagm Sep 19, 2024

benjagm Sep 19, 2024

benjagm Sep 19, 2024

benjagm Sep 19, 2024

nikhilkalburgi commented Sep 20, 2024

benjagm left a comment

benjagm Sep 23, 2024

benjagm Sep 23, 2024

nikhilkalburgi commented Sep 23, 2024

gregsdennis commented Sep 23, 2024

nikhilkalburgi commented Sep 24, 2024

benjagm left a comment

	SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }}
	SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_GEN_NOTIF }}

	- cron: '50 21 * * 1' # Runs at 21:50 UTC, which is 10 minutes before 14:00 PT every Monday
	- cron: '50 18 15-21 * 1' # Runs at 11:50 AM PT on the 3rd Monday of the month

	body: "The meeting as been cancelled as there is no agenda for today. Thanks"
	body: "The meeting has been cancelled as there is no agenda for today. Thanks everyone!"

	text: `The meeting as been cancelled as there is no agenda for today. Thanks`
	text: `The meeting has been cancelled as there is no agenda for today. Thanks everyone!`


		- name: Install Dependencies
		run: npm install @octokit/[email protected]

+    # Step to check if today is the third Monday
+    - name: Check if today is the third Monday
+      id: check-third-monday
+      run: |
+        day=$(date +%d)
+        dow=$(date +%u)  # Day of the week (1 = Monday, ..., 7 = Sunday)
+        # Check if the day is between 15th and 21st, and if it's Monday (1)
+        if [ "$dow" -ne 1 ]; then
+          echo "Not a Monday, exiting..."
+          exit 0
+        fi
+        if [ "$day" -ge 15 ] && [ "$day" -le 21 ]; then
+          echo "This is the third Monday of the month!"
+        else
+          echo "Not the third Monday, exiting..."
+          exit 0
+        fi

add workflow for Agenda Verification and Notifications before Monday Meetings #802

add workflow for Agenda Verification and Notifications before Monday Meetings #802

Conversation

nikhilkalburgi commented Sep 16, 2024

benjagm left a comment

Choose a reason for hiding this comment

benjagm Sep 19, 2024

Choose a reason for hiding this comment

benjagm Sep 19, 2024

Choose a reason for hiding this comment

benjagm Sep 19, 2024

Choose a reason for hiding this comment

benjagm Sep 19, 2024

Choose a reason for hiding this comment

nikhilkalburgi commented Sep 20, 2024

benjagm left a comment

Choose a reason for hiding this comment

benjagm Sep 23, 2024

Choose a reason for hiding this comment

benjagm Sep 23, 2024

Choose a reason for hiding this comment

nikhilkalburgi commented Sep 23, 2024

gregsdennis commented Sep 23, 2024

nikhilkalburgi commented Sep 24, 2024

benjagm left a comment

Choose a reason for hiding this comment