-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated cache:true instructions for $.getScript #1054
base: main
Are you sure you want to change the base?
Conversation
The signature of passing a settings object instead of URL string was added on jQuery 1.12 but not documented. Added the signature and updated the cache related workarounds and examples to reflect the new signature. The example with loading jquery-color was edited to support caching because browser caching is highly recommended when loading a plugin code.
The signature of passing a settings object instead of URL string was added on jQuery 1.12. Added the signature and updated the workarounds and examples to reflect the new signature. The example of loading jquery-color was edited to support caching because browser caching is highly recommended when loading a plugin code.
Hi @oriadam, thank you for your contribution. Could you update the examples in your PR to match our style guide? You can find the guide here: https://contribute.jquery.org/style-guide/js/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JavaScript Style Guide
Hi @AurelioDeRosa be glad to :) is it ok now ? |
We don't seem to have a style guide for XML documents. The one that @AurelioDeRosa links to describes only JS. We have an HTML doc but our XML files aren't really close to that. @oriadam I think all XML files should be aligned with each other so they should all use 2-space indentation. |
$.getScript signature of passing a settings object instead of URL string was added on jQuery 1.12.
Added the signature to documentation and updated the related workarounds and examples to include the new signature.
The example with loading jquery-color was edited to support caching, as caching is highly recommended when loading a plugin.