-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$.getScript is missing a signature #1052
Comments
Thanks for the report. Would you like to submit a PR? |
Created PR 1054 |
Looking into it now, I think this signature is still not supported. It only works by accident due to changes in Would you open an issue there to discuss adding official support? Once it's accepted, we would accept a PR. |
Sure, opened the issue: The code looks good, doesn't look like accident. |
…oads for `jQuery.getScript` and Data APIs. (#29573) * [jquery] Introduce interface for `jQuery.fx`. * [jquery] Attach `jQuery.Deferred` documentation to correct symbol. * [jquery] Convert `jQuery.Callbacks` to an interface. This change is purely for consistency with similar properties (e.g. `jQuery.Deferred`, `jQuery.Event`). * [jquery] For `JQuery`, reduce examples to only those relevant to the overload and use shorter template for code-only examples. * [jquery] For `JQueryStatic`, reduce examples to only those relevant to the overload and use shorter template for code-only examples. * [jquery] For `JQuery.Event`, reduce examples to only those relevant to the overload and use shorter template for code-only examples. * [jquery] For `JQuery.Callbacks`, reduce examples to only those relevant to the overload and use shorter template for code-only examples. * [jquery] For `JQuery.PromiseBase`/`JQuery.Deferred`, reduce examples to only those relevant to the overload and use shorter template for code-only examples. * [jquery] Consistent ordering. * [jquery] Add `jQuery.getScript(options)`. See jquery/api.jquery.com#1052. * [jquery] Fix documentation for this one overload of `jQuery.proxy`. * [jquery] Accept `Document`, `Window`, and `JQuery.PlainObject` for the `element` parameter of Data APIs. See https://github.com/jquery/jquery/blob/354f6036f251a3ce9b24cd7b228b4c7a79001520/test/unit/data.js#L142-L164 and jquery/api.jquery.com#1035. * [jquery] Add `jQuery.cleanData`. See jquery/api.jquery.com#996.
jQuery 1.12.0 added a signature for passing an options object to $.getScript.
The options are padded on to $.ajax.
The above example should be added to the examples section, for jQuery 1.12.0 or later.
https://api.jquery.com/jquery.getscript/
The text was updated successfully, but these errors were encountered: