Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append custom message to notification, configurable per Project (includes var evaluation). #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gagnechris
Copy link

I reviewed the existing pull requires and non of them really accomplished what I was trying to do. The Mustache templates change is much more than I need and the 'Add custom message variable' is too simple (note configurable per project and doesn't eval variables). Here is what I was trying to accomplish:

  1. Give the option to append a custom message to messages sent to hipchat.
  2. If the custom message references variables (i.e. ${var_name}), evaluate them.
  3. The custom message need to be configurable on a per-project basis.

The PR accomplishes this. I see this as being a nice option along side the other PR currently being considered.

Please let me know what you think. Thanks!

…ed. Also added Conditional Notify parameter, where you can supply a boolean parameter indicating if a notification should be sent.
@redndahead
Copy link

I like this approach. While I'm not able to evaluate the code I think this approach is what I have been looking for. We have build parameters and this would help us to identify what the actual build is.

@FGRibreau
Copy link

👍 Feels pretty good to me

@valdisrigdon
Copy link

👍

@adrienDog
Copy link

Hey all! Was just wondering if there was an update on this issue ?
Thanks !

@NaxYo
Copy link

NaxYo commented Aug 19, 2014

+1

2 similar comments
@giancarlogarcia
Copy link

+1

@matthiasbalke
Copy link

+1

@LotharSee
Copy link

👍 I don't know about this code change but this feature would be great!
For example, to notify the person who broke (or fixed) the build directly on Hipchat.

@mirfilip
Copy link

mirfilip commented Nov 5, 2014

Definitely +1

@aljets
Copy link

aljets commented Nov 6, 2014

+1

@leinaddm
Copy link

any update on this one?

@tehmaspc
Copy link

+1 on this feature.

@in4mer
Copy link

in4mer commented Dec 31, 2014

Merge this and let us move on, please.

@GuillaumeDievart
Copy link

+1

@estevejm
Copy link

Why this remains unchanged after so long? Please, could you merge this feature?

@tehmaspc
Copy link

someone w/ time and jenkins plugin dev experience should simply fork this repo and take pull requests for new features there.

@Pindar
Copy link

Pindar commented Feb 25, 2015

+1

1 similar comment
@ghost
Copy link

ghost commented Mar 24, 2015

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.