-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append custom message to notification, configurable per Project (includes var evaluation). #45
base: master
Are you sure you want to change the base?
Conversation
…ld notifications to hipchat
…ed. Also added Conditional Notify parameter, where you can supply a boolean parameter indicating if a notification should be sent.
I like this approach. While I'm not able to evaluate the code I think this approach is what I have been looking for. We have build parameters and this would help us to identify what the actual build is. |
👍 Feels pretty good to me |
👍 |
Hey all! Was just wondering if there was an update on this issue ? |
+1 |
2 similar comments
+1 |
+1 |
👍 I don't know about this code change but this feature would be great! |
Definitely +1 |
+1 |
any update on this one? |
+1 on this feature. |
Merge this and let us move on, please. |
+1 |
Why this remains unchanged after so long? Please, could you merge this feature? |
someone w/ time and jenkins plugin dev experience should simply fork this repo and take pull requests for new features there. |
+1 |
1 similar comment
+1 |
I reviewed the existing pull requires and non of them really accomplished what I was trying to do. The Mustache templates change is much more than I need and the 'Add custom message variable' is too simple (note configurable per project and doesn't eval variables). Here is what I was trying to accomplish:
The PR accomplishes this. I see this as being a nice option along side the other PR currently being considered.
Please let me know what you think. Thanks!