Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to customise the HipChat notification message at the job level #25

Closed
BrunoLavitForgerock opened this issue Nov 19, 2014 · 5 comments
Assignees
Labels
Milestone

Comments

@BrunoLavitForgerock
Copy link

This plugin is very helpful to notify our developers and QAs.
To improve the notification, we would like to be able to customise the HipChat notification message at the job level.
With this custom message, we could be able to use some Jenkins or Maven properties: https://blog.codecentric.de/en/2014/07/accessing-maven-project-properties-jenkins-build-jobs/
If a custom message is set at the job level, the plugin should use it.
Otherwise, the plugin should use the default message (like today).
Thanks to the hipchat-plugin team :)

@frankier
Copy link

Heya. Check out this: jlewallen#32 . If there's any interest from the maintainer of this repository I could rebase + squash that pull request against this repository + possibly clean things up if need be a bit and submit a new pull request.

@aldaris
Copy link

aldaris commented Nov 25, 2014

Thanks for the link. :) I've been looking through the pull requests, and this indeed looks interesting (though I don't fully understand what it does yet :)). My current plans are to consolidate the configuration and add support for v2 API for the next (0.1.9) release, but I think this could become a good addition for the 0.2.0 release.

@rouge8
Copy link

rouge8 commented Feb 19, 2015

jlewallen#45 also looks promising

@retoo
Copy link

retoo commented Feb 21, 2015

@aldaris please see my pull request. Let me know if you require any changes :).

retoo added a commit to retoo/hipchat-plugin that referenced this issue Feb 23, 2015
@mdlinville
Copy link

I'd like to vote for this too.

@aldaris aldaris closed this as completed in 228d6ac Mar 9, 2015
aldaris added a commit that referenced this issue Mar 9, 2015
@aldaris aldaris self-assigned this Mar 9, 2015
@aldaris aldaris added this to the 0.1.9 milestone Mar 9, 2015
@aldaris aldaris added the RFE label Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants