Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-48466] Provide JUnit 5 support for JenkinsRule #560

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

basil
Copy link
Member

@basil basil commented Jun 14, 2022

See jenkinsci/jenkins-test-harness#438 for the PR description.

@basil basil marked this pull request as ready for review July 18, 2022 17:38
@@ -164,9 +164,11 @@
<version>3.1.0</version>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason this was removed from dependency management?

junit-bom does not include a junit version

@jglick
Copy link
Member

jglick commented Jul 28, 2023

For the record, parameterized test selection no longer seems to work in plugins (discovered in jenkinsci/workflow-durable-task-step-plugin#323); based on comments in SUREFIRE-2010 I suspect the use of the Jupiter engine (even for JUnit 4 tests) is the cause, and unfortunately apache/maven-surefire#476 is stalled.

jglick added a commit to jglick/durable-task-plugin that referenced this pull request Aug 18, 2023
…un e.g. `mvn test -Dtest="BourneShellScriptTest#binaryCaching[0: ON_CONTROLLER]"`
@jglick
Copy link
Member

jglick commented Aug 18, 2023

Workaround, based on this tip, presuming that the plugin does not in fact contain any Jupiter-based tests:

<build>
    <pluginManagement>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-surefire-plugin</artifactId>
                <dependencies>
                    <dependency>
                        <groupId>org.apache.maven.surefire</groupId>
                        <artifactId>surefire-junit47</artifactId>
                        <version>${maven-surefire-plugin.version}</version>
                    </dependency>
                </dependencies>
            </plugin>
        </plugins>
    </pluginManagement>
</build>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants