-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-48466] Provide JUnit 5 support for JenkinsRule
#560
Conversation
@@ -164,9 +164,11 @@ | |||
<version>3.1.0</version> | |||
</dependency> | |||
<dependency> | |||
<groupId>junit</groupId> | |||
<artifactId>junit</artifactId> | |||
<version>4.13.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason this was removed from dependency management?
junit-bom does not include a junit
version
For the record, parameterized test selection no longer seems to work in plugins (discovered in jenkinsci/workflow-durable-task-step-plugin#323); based on comments in SUREFIRE-2010 I suspect the use of the Jupiter engine (even for JUnit 4 tests) is the cause, and unfortunately apache/maven-surefire#476 is stalled. |
…un e.g. `mvn test -Dtest="BourneShellScriptTest#binaryCaching[0: ON_CONTROLLER]"`
Workaround, based on this tip, presuming that the plugin does not in fact contain any Jupiter-based tests: <build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit47</artifactId>
<version>${maven-surefire-plugin.version}</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</pluginManagement>
</build> |
See jenkinsci/jenkins-test-harness#438 for the PR description.