More efficient lastLocation handling in watch mode
#187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwnusbaum
approved these changes
Aug 18, 2023
car-roll
approved these changes
Aug 18, 2023
Though `.watch` actually ran decent test coverage of push mode, JaCoCo did not show `Watcher` since all the tests ran on agents in another JVM. Adding a mode to run on-controller since people do sometimes do that, and it should show up in JaCoCo, and log messages from the watcher go to test output which is helpful.
This comment was marked as resolved.
This comment was marked as resolved.
…un e.g. `mvn test -Dtest="BourneShellScriptTest#binaryCaching[0: ON_CONTROLLER]"`
…ion of `binaryPath`
dwnusbaum
approved these changes
Aug 18, 2023
jglick
commented
Aug 18, 2023
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <dependencies> | ||
| <!-- https://github.com/jenkinsci/plugin-pom/pull/560#issuecomment-1656232490 --> |
There was a problem hiding this comment.
| FilePath lastLocationFile = controller.getLastLocationFile(workspace); | ||
| if (lastLocationFile.exists()) { | ||
| lastLocation = Long.parseLong(lastLocationFile.readToString()); | ||
| LOGGER.finest(() -> "Loaded lastLocation=" + lastLocation); |
There was a problem hiding this comment.
Seems to actually be missing from test coverage in this plugin currently; workflow-durable-task-step does exercise it in tests relating to agent disconnections and controller restarts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the task recurs every 100ms, it seems unnecessary to read a file that we just wrote to disk.