-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add null alt text to several images #9296
base: master
Are you sure you want to change the base?
Changes from 3 commits
7c874c4
08fc4b7
4a2c910
8cf6508
6d4fa24
c7867b2
4d8fd42
9eafafe
e16257d
1b731b5
6275984
b782620
87d4ab4
904cb3e
8d861dd
690501b
23d56f1
f110180
1806b45
42f2883
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -61,7 +61,7 @@ THE SOFTWARE. | |||||
</j:otherwise> | ||||||
</j:choose> | ||||||
</div> | ||||||
<img src="graph?type=${type}&width=500&height=300" /> | ||||||
<img src="graph?type=${type}&width=500&height=300" alt="null" /> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this is the memory usage monitor graph, I think that the alt text should say that. The word "null" won't help a disabled user understand what is being shown in the image.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolved in 904cb3e |
||||||
</l:main-panel> | ||||||
</l:layout> | ||||||
</j:jelly> |
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -32,7 +32,7 @@ THE SOFTWARE. | |||||||||
<l:header /> | ||||||||||
<l:main-panel> | ||||||||||
<h1 style="text-align: center"> | ||||||||||
<img src="${imagesURL}/rage.svg" height="179" width="154"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span> | ||||||||||
<img src="${imagesURL}/rage.svg" height="179" width="154" alt="null"/> <span style="font-size:50px"><st:nbsp/>${%Oops!}</span> | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Decorative only. Also,
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Resolved in 4d8fd42 |
||||||||||
</h1> | ||||||||||
<div id="error-description"> | ||||||||||
<h2 style="text-align: center">${%problemHappened}</h2> | ||||||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jenkins is an English language proper noun. It needs to be capitalized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to be localizable.Additionally I am not sure welcome page adequately describes what this is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that we can localize the text in pages that are generated by GitHub Actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I managed to comment this on the only file it doesn't apply to 😅 (all your suggestions are not localizable).