Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add null alt text to several images #9296

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Feature/add null alt text to several images #9296

wants to merge 20 commits into from
+10 −10

Commits on May 21, 2024

  1. Merge pull request #1 from jenkinsci/master 

    merging current changes
    @JanhviHarwani
    JanhviHarwani authored May 21, 2024
    Configuration menu
    Copy the full SHA
    7c874c4 View commit details
    Browse the repository at this point in the history

  2. Added alt attribute to all img tag

    @janhvi-simform
    janhvi-simform committed May 21, 2024
    Configuration menu
    Copy the full SHA
    08fc4b7 View commit details
    Browse the repository at this point in the history

  3. Added null as text in alt attribute

    @janhvi-simform
    janhvi-simform committed May 21, 2024
    Configuration menu
    Copy the full SHA
    4a2c910 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Merge pull request #2 from jenkinsci/master 

    merge jenkins master branch to feature/add-null-text
    @JanhviHarwani
    JanhviHarwani authored May 24, 2024
    Configuration menu
    Copy the full SHA
    8cf6508 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/JanhviHarwani/jenkins int… 

    …o feature/add-null-text-alt
    @janhvi-simform
    janhvi-simform committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6d4fa24 View commit details
    Browse the repository at this point in the history

  3. Merge pull request #3 from jenkinsci/master 

    merging to local branch
    @JanhviHarwani
    JanhviHarwani authored May 24, 2024
    Configuration menu
    Copy the full SHA
    c7867b2 View commit details
    Browse the repository at this point in the history

  4. Resolved all the PR comments

    @janhvi-simform
    janhvi-simform committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4d8fd42 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'feature/add-null-text-alt' of https://github.com/Janhvi… 

    …Harwani/jenkins into feature/add-null-text-alt
    @janhvi-simform
    janhvi-simform committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9eafafe View commit details
    Browse the repository at this point in the history

  6. Updated alt image messages for dir.jelly, _404_simple.jelly and execu… 

    …tors.jelly
    @janhvi-simform
    janhvi-simform committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e16257d View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Merge branch 'master' into feature/add-null-text-alt

    @daniel-beck
    daniel-beck authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1b731b5 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Merge branch 'master' into feature/add-null-text-alt

    @MarkEWaite
    MarkEWaite committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    6275984 View commit details
    Browse the repository at this point in the history

  2. Do not attempt to localize Jenkins welcome page alt text

    @MarkEWaite
    MarkEWaite committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    b782620 View commit details
    Browse the repository at this point in the history

  3. More clearly describe the participate link 

    The destination page is describing the Jenkins project, not just
Jenkins core.

Addresses the comment in:
jenkinsci#9296 (comment)
    @MarkEWaite
    MarkEWaite committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    87d4ab4 View commit details
    Browse the repository at this point in the history

  4. Internationalize memory usage monitor graph

    @MarkEWaite
    MarkEWaite committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    904cb3e View commit details
    Browse the repository at this point in the history

  5. Use empty alt text when immediately followed by text 

    As noted by Daniel Beck, it does not help the user of the screen
reader for us to show the same fundamental text message twice.  The
image in these cases is a hint for the reader of the message text that
immediately follows the image.  Cluttering the screen reader content
with a second copy of the same message is not helpful.
    @MarkEWaite
    MarkEWaite committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    8d861dd View commit details
    Browse the repository at this point in the history

  6. Use empty alt text in dropdown documentation example

    @MarkEWaite
    MarkEWaite committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    690501b View commit details
    Browse the repository at this point in the history

  7. Use empty alt text because nearby text already has the message 

    No need to display the "not found" message twice in locations very
near to each other.
    @MarkEWaite
    MarkEWaite committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    23d56f1 View commit details
    Browse the repository at this point in the history

  8. Use empty alt text - nearby text already provides details

    @MarkEWaite
    MarkEWaite committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    f110180 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Merge branch 'master' into feature/add-null-text-alt

    @MarkEWaite
    MarkEWaite committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    1806b45 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feature/add-null-text-alt

    @MarkEWaite
    MarkEWaite committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    42f2883 View commit details
    Browse the repository at this point in the history