Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump jenkins.version from 2.399 to 2.400 for bom-weekly #1959

Closed
wants to merge 2 commits into from
Closed

Bump jenkins.version from 2.399 to 2.400 for bom-weekly #1959

wants to merge 2 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 11, 2023 •
edited
Loading

Bump jenkins.version from 2.399 to 2.400 for bom-weekly

Report

Source:
	✔ [jenkins] Get Last jenkins Weekly Version(jenkins)


Condition:
	✔ [jenkins] Test if Jenkins stable published(maven)

Target:
	✔ [jenkins] Update Jenkins version(shell)

Changelog

Click to expand 
Jenkins changelog is available at: https://www.jenkins.io/changelog/#v2.400

Remark

This pull request was automatically created using Updatecli.

Please report any issues with this tool here

@github-actions
chore: ran shell command "pwsh -NoProfile -File /home/runner/work/bom...
b8576f1 
... /bom/updatecli/update-jenkins.ps1 weekly 2.400"

Made with ❤️️ by updatecli
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Apr 11, 2023
@MarkEWaite MarkEWaite enabled auto-merge (squash) April 11, 2023 23:34
MarkEWaite
MarkEWaite reviewed Apr 14, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shows a real failure in the pipeline-groovy-lib-plugin releases 656.va_a_ceeb_6ffb_f7 and 629.vb_5627b_ee2104 when tested with the command:

$ git clone https://github.com/jenkinsci/pipeline-groovy-lib-plugin.git
$ cd pipeline-groovy-lib-plugin
$ mvn clean -Dtest=LibraryStepTest#configRoundtrip -Djenkins.version=2.400 verify
org.kohsuke.stapler.NoStaplerConstructorException: There's no @DataBoundConstructor on any constructor of class hudson.model.utils.AbortExceptionPublisher
        at org.kohsuke.stapler.ClassDescriptor.loadConstructorParamNames(ClassDescriptor.java:276)
        at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:862)
        at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:766)
Caused: java.lang.IllegalArgumentException: Failed to instantiate class hudson.model.utils.AbortExceptionPublisher from {"stapler-class":"hudson.model.utils.AbortExceptionPublisher","$class":"hudson.model.utils.AbortExceptionPublisher"}
        at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:769)
        at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:549)
        at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:544)
        at hudson.model.Descriptor.bindJSON(Descriptor.java:622)
        at hudson.model.Descriptor.newInstance(Descriptor.java:592)
Caused: java.lang.LinkageError: Failed to instantiate class hudson.model.utils.AbortExceptionPublisher from {"stapler-class":"hudson.model.utils.AbortExceptionPublisher","$class":"hudson.model.utils.AbortExceptionPublisher"}
        at hudson.model.Descriptor.newInstance(Descriptor.java:595)
        at hudson.model.Descriptor.newInstancesFromHeteroList(Descriptor.java:1095)
        at hudson.model.Descriptor.newInstancesFromHeteroList(Descriptor.java:1057)
        at hudson.util.DescribableList.rebuildHetero(DescribableList.java:210)
        at hudson.model.Project.submit(Project.java:234)
        at hudson.model.Job.doConfigSubmit(Job.java:1348)
        at hudson.model.AbstractProject.doConfigSubmit(AbstractProject.java:772)
        at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:710)
        at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:397)

I've not yet diagnosed which comment to Jenkins core 2.400 introduced the change that broke the test, but that is a step I'll take later (or someone else can do the bisect to locate the commit with the issue).

I assume the failure occurs in all recent releases of pipeline-groovy-lib plugin.

@MarkEWaite
Copy link
Contributor

I've bisected the change in Jenkins core to jenkinsci/jenkins@96daec6 from pull request:

This looks like it may be an example of a problem resulting from the outdated JavaScript support in HTMLUnit as noted by @basil in jenkinsci/jenkins-test-harness#569 (comment)

I assume that we need to find a way to allow the LibraryStepTest#configRoundtrip test in pipeline-groovy-lib-plugin to pass when running on a Jenkins version that is no longer using Prototype.js in the hetero-list.js file. More investigation tomorrow.

@MarkEWaite MarkEWaite mentioned this pull request Apr 14, 2023
Closed
6 tasks
MarkEWaite added a commit to MarkEWaite/pipeline-groovy-lib-plugin that referenced this pull request Apr 14, 2023
@MarkEWaite
Exclude HTMLUnit failing assertion in Jenkins 2.400 and later
073f9dd 
jenkinsci/bom#1959 (comment)
explains that the modernization of hetero-list.js has inserted JavaScript
that the HTMLUnit JavaScript engine does not understand.  That causes
the test to fail with an HTTP 500 error when the specific assertion
is executed.

Do not execute the failing assertion on Jenkins 2.400 and
later.  Excluding the failing assertion is a simple short-term
workaround for the larger problem that is described by @basil in
jenkinsci/jenkins-test-harness#569 (comment)
@MarkEWaite
Copy link
Contributor

The failures in branch-api tests will need more investigation. They seem to have additional failures beyond the errors due to outdated JavaScript support in HTMLUnit.

@basil
Copy link
Member

basil commented Apr 14, 2023

The failures in branch-api tests will need more investigation. They seem to have additional failures beyond the errors due to outdated JavaScript support in HTMLUnit.

Both failures have the same cause: jenkinsci/jenkins#7840

@basil
Copy link
Member

basil commented Apr 14, 2023

I found the actual root cause in jenkinsci/jenkins#7845.

@MarkEWaite
Copy link
Contributor

@dependabot close

Needs 2.401 before we're ready to merge

@MarkEWaite MarkEWaite closed this Apr 15, 2023
auto-merge was automatically disabled April 15, 2023 02:41

Pull request was closed

@MarkEWaite MarkEWaite deleted the updatecli_04dda47962097893b55ad8b81532d001822f067aaf4870f0c3f8346585ca19d4 branch April 15, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkEWaite @basil