Exclude HTMLUnit failing assertion in Jenkins 2.400 and later #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenkinsci/bom#1959 (comment) explains that the modernization of hetero-list.js has inserted JavaScript that the HTMLUnit JavaScript engine does not understand. That causes the test to fail with an HTTP 500 error when the specific assertion is executed. Do not execute the failing assertion on Jenkins 2.400 and later. Excluding the failing assertion is a simple short-term workaround for the larger problem that is described by @basil in jenkinsci/jenkins-test-harness#569 (comment)
Check the assertion works on newer Jenkins
|
jenkinsci/jenkins#7845 makes this change unnecessary. Closing this pull request on the assumption that it is better to make the change in Jenkins core and benefit both this plugin and branch-api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude HTMLUnit failing assertion in Jenkins 2.400 and later
jenkinsci/bom#1959 (comment) explains that the modernization of hetero-list.js has inserted JavaScript that the HTMLUnit JavaScript engine does not understand. That causes the test to fail with an HTTP 500 error when the specific assertion is executed.
Do not execute the failing assertion on Jenkins 2.400 and later. Excluding the failing assertion is a simple short-term workaround for the larger problem that is described by @basil in jenkinsci/jenkins-test-harness#569 (comment)