This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
First Pass At StyleCop Integration #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Emby.AutoOrganize/Core/Extensions.cs Emby.AutoOrganize/Data/SqliteFileOrganizationRepository.cs Emby.AutoOrganize/Model/FileOrganizationResult.cs Emby.AutoOrganize/Model/SmartMatchInfo.cs Emby.AutoOrganize/Model/SmartMatchResult.cs
mark-monteiro
commented
Jan 6, 2020
| [SuppressMessage("Usage", "CA2227:Collection properties should be read only", Justification = "This property needs to support serialization by both ServiceStack and XmlSerializer")] | ||
| public List<SmartMatchInfo> SmartMatchInfos { get; set; } | ||
| public List<SmartMatchInfo> SmartMatchInfos { get; set; } = new List<SmartMatchInfo>(); |
There was a problem hiding this comment.
Property is initialized here to avoid using the obsolete SmartMatchInfo class in the constructor, which raises an additional warning.
mark-monteiro
commented
Jan 6, 2020
| <Rule Id="SA1611" Action="Info" /> | ||
| <!-- disable Warning SA1649: File name should match first type --> | ||
| <Rule Id="SA1649" Action="Info" /> | ||
| </Rules> |
There was a problem hiding this comment.
Disabling these rules for now, I will remove these ruleset entries one-by one in future PRs.
Bond-009
reviewed
Mar 4, 2020
Bond-009
suggested changes
Mar 4, 2020
No problem, this isn't something I care about merging quickly ;) All done with the first few changes you suggested. |
Bond-009
approved these changes
Mar 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a first pass at integrating StyleCop, addressing many of the outstanding issues.
I am splitting this into multiple PRs to make code review more manageable. For example, in the next PR I will probably tackle all the instances of multiple classes per file, which would produce a fairly unreadable diff if it was combined with this PR. For now, the unaddressed StyleCop issues have been disabled in the .ruleset file.