This repository has been archived by the owner on Feb 28, 2022. It is now read-only.
Fix StyleCop Issues - Document Parameters #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mark-monteiro still a draft? |
No, was just waiting for the previous PR to get merged so this didn't get reviewed/merged out-of order |
Bond-009
suggested changes
Mar 12, 2020
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition=" '$(Configuration)' == 'Release' "> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> |
There was a problem hiding this comment.
How would you do that? I tried this but then the project wouldn't load:
<PropertyGroup Condition=" '$(Configuration)' == 'Release' " TreatWarningsAsErrors="true"/>
error : The attribute "TreatWarningsAsErrors" in element is unrecognized.
There was a problem hiding this comment.
<TreatWarningsAsErrors Condition=" '$(Configuration)' == 'Release' ">true</TreatWarningsAsErrors>And put it in the PropertyGroup above
Bond-009
approved these changes
Mar 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on PR #23 and should not be reviewed/merged until that one has been merged