Fix/594 exports #604
Open
Fix/594 exports #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekynoxe
commented
Oct 5, 2023
There was a problem hiding this comment.
The project seems to be using yarn, so this file is unnecessary and was generating warnings running yarn
ekynoxe
commented
Oct 5, 2023
| @@ -8,7 +8,14 @@ | |||
| ], | |||
| "scripts": { | |||
| "install": "cd src/danfojs-base && yarn && cd ../danfojs-browser && yarn && cd ../danfojs-node && yarn", | |||
| "build": "cd src/danfojs-node && yarn build:clean && cd ../danfojs-browser && yarn build:clean", | |||
| "test": "cd src/danfojs-base && yarn && cd ../danfojs-node && yarn && yarn test:clean && cd ../danfojs-browser && yarn && yarn test:clean" | |||
| "build": "yarn build:browser && yarn build:node", | |||
There was a problem hiding this comment.
This comes from my other PR #603 so I could run build and tests independently from the root of the project
ekynoxe
commented
Oct 5, 2023
| "module": "lib/bundle-esm.js", | ||
| "exports": { | ||
| ".": { | ||
| "types": "./dist/danfojs-browser/src/index.d.ts", |
There was a problem hiding this comment.
I'm really unsure about the correct syntax here.
|
This fix makes the package run on Vite. Pls merge this fix. |
|
I hit this today attempting to try out danfojs for the first time. Any plans to merge in the fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #594 (and maybe also #545 and #527)
For a new vite app, a new CRA app and a new Vuew app, I've linked the package locally with
npm link danfojs, then used the following code in the root file:Both apps run fine without runtime errors and display the series in the console.
However, types don't work, and I get the following error in CRA terminal output:
I'm also new to package exports, so it's all a little blurry, but hopefully that's a start to fix the issues and could do with some help to finish it off.