Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix for tests #603

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ekynoxe
Copy link

@ekynoxe ekynoxe commented Oct 5, 2023

Browser tests are filing as the bundle file Karma tries to load is not found and frontend tests fail to even start.

It looks like the issue was introduced by #516 and I'm not sure what it aimed to solve since the esbuild generated file is bundle.esm.js, whilst the webpack one was bundle-esm.js (simply bundle.js with this PR.)

I think the file rename was unnecessary, so I've reverted that.

We could also update the karma configuration file to use bundle-esm.js, it fixes the browser tests as well.

There seems to be a process to publish the module that renames the bundle-esm.js file to bundle.js. I don't know why we need to name the webpack generated file with the -esm suffix.
@ekynoxe ekynoxe force-pushed the fix/bundle-file-for-tests branch from 5ba1970 to f62bdd3 Compare October 5, 2023 11:12
@ekynoxe ekynoxe mentioned this pull request Oct 5, 2023
@steveoni
Copy link
Member

steveoni commented Oct 7, 2023

@ekynoxe did you also check if it fix this issue #514 as suggested by #516

@ekynoxe
Copy link
Author

ekynoxe commented Oct 9, 2023

@steveoni for me, when linking danfojs from a new vue app, master doesn't work. I get the same error describe in #594 .
So this particular PR doesn't fix #514, but my PR #604 does. I'll update the description that it also works with a new Vuew project.

Screenshot 2023-10-09 at 09 31 54

@rchavp
Copy link

rchavp commented Dec 12, 2023

Has anyone figured out how to fix this issue? I was really looking forward to using this library in our production pipeline, but I can't remove Vite unfortunately and local hacks/fixes are a no go either.

@ekynoxe
Copy link
Author

ekynoxe commented Dec 18, 2023

Has anyone figured out how to fix this issue? I was really looking forward to using this library in our production pipeline, but I can't remove Vite unfortunately and local hacks/fixes are a no go either.

I'm afraid we've had zero feedback from the maintainers on either of my PRs, so we can't do much anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants