Restructure moveit config #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ipa-mdl @ipa-nhg please review/comment I think we should squash/rebase/cherry-pick this PR after review... |
fmessmer
force-pushed
the
restructure_moveit_config
branch
from
773bea4 to
58c39d5
Compare
fmessmer
force-pushed
the
restructure_moveit_config
branch
from
58c39d5 to
365f8a9
Compare
|
commit log has been cleaned up (proper rebase and extraction of cob4-10 fixes into separate PR #570) |
mathias-luedtke
approved these changes
Dec 16, 2016
| @@ -1,13 +1,10 @@ | |||
| <?xml version="1.0"?> | |||
| <launch> | |||
|
|
|||
| <arg name="robot" default="$(optenv ROBOT !!NO_ROBOT_SET!!)"/> | |||
There was a problem hiding this comment.
I'm reverting it to how it has always been before I left 😉
We used to use tabs in all our launch files....
There was a problem hiding this comment.
Tabs are really annoying..
(my default editor does not handle them properly :-/)
This was referenced Jan 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaces #518
requires ipa320/cob_manipulation#88
We will keep the moveit_config files separate from
cob_hardware_configfiles in a dedicatedcob_moveit_configpackage including only config files (no moveit launch files) for easier maintainability.However, we could move (with history)
cob_moveit_configfromcob_manipulationintocob_robotsin order to have all configuration at one place.We will deal with debugging the functionality of the collision_monitor later, i.e. investigate why wrong collisions are reported and fix model as well as SRDFs...related issue is ipa320/cob_manipulation#89