Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Add XFAIL trackers for improperly XFAIL-ed E2E tests #16421

Merged
merged 52 commits into from
Jan 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
8a231d1
Add XFAIL trackers for several tests
lbushi25 Dec 5, 2024
abd8fd3
Add XFAIL trackers for several tests
lbushi25 Dec 5, 2024
5edd0ad
Add XFAIL trackers for several more tests
lbushi25 Dec 5, 2024
dda50ca
Add XFAIL trackers for several more tests
lbushi25 Dec 5, 2024
87856a7
Reduce number of tests without XFAIL tracker
lbushi25 Dec 5, 2024
8d10473
Fix wrong tracker in span.cpp test
lbushi25 Dec 5, 2024
0f2daf2
Delete tests failing because of GSD-4509 issue
lbushi25 Dec 5, 2024
7bd5922
Remove XFAILs for hip nvidia plaform
lbushi25 Dec 6, 2024
b5471f8
Fix formatting
lbushi25 Dec 6, 2024
6df2d88
Fix typos and remove the tests from the list of improperly XFAIL-ed t…
lbushi25 Dec 6, 2024
357539d
Delete rogue file
lbushi25 Dec 6, 2024
999006d
Add tracking infor for XFAIL tests and remove hip_nvidia xfails
lbushi25 Dec 9, 2024
eec9ac6
Merge branch 'add_xfail_trackers' of https://github.com/lbushi25/llvm…
lbushi25 Dec 9, 2024
f307817
Merge branch 'intel:sycl' into add_xfail_trackers
lbushi25 Dec 9, 2024
e9df0a4
Uncomment check commands to get failures
lbushi25 Dec 9, 2024
3be9b21
Add XFAIL tracker issue to kernel-bundle-merge-options.cpp
lbushi25 Dec 9, 2024
58a3767
Update number of XFAILs without tracker
lbushi25 Dec 9, 2024
48ed23e
Update no-xfail-without-tracker.cpp
lbushi25 Dec 9, 2024
78eefa4
Update int.cpp
lbushi25 Dec 9, 2024
a50cc22
Add XFAIL trackers for joint matrix tests
lbushi25 Dec 12, 2024
b496bc7
Merge branch 'add_xfail_trackers' of https://github.com/lbushi25/llvm…
lbushi25 Dec 12, 2024
7cbfaca
Update count of improperly XFAIL-ed tests
lbushi25 Dec 12, 2024
622e2cd
Merge branch 'sycl' into add_xfail_trackers
lbushi25 Dec 12, 2024
03e9e85
Update count of improperly XFAIL-ed tests
lbushi25 Dec 12, 2024
69a1db1
Merge branch 'add_xfail_trackers' of https://github.com/lbushi25/llvm…
lbushi25 Dec 12, 2024
67f5400
Add XFAIL trackers for E2E tests
lbushi25 Dec 18, 2024
c6600a7
Update number of improperly XFAIL-ed tests
lbushi25 Dec 18, 2024
213f2b0
Resolve meerge conflict
lbushi25 Dec 18, 2024
4545707
revert hardware_dispatch.cpp
lbushi25 Dec 18, 2024
fd0be54
Update number of improperly XFAIL-ed tests
lbushi25 Dec 18, 2024
6463e50
Update number of improperly XFAIL-ed tests
lbushi25 Dec 18, 2024
d29ac1e
Modify improper XFAIL checking by not running FileCheck if there are …
lbushi25 Dec 18, 2024
184f628
Update no-xfail-without-tracker.cpp
lbushi25 Dec 18, 2024
d8b9588
Modify improper XFAIL checking by not running FileCheck if there are …
lbushi25 Dec 18, 2024
cbb9b7c
Merge branch 'add_trackers_XFAIL' of https://github.com/lbushi25/llvm…
lbushi25 Dec 18, 2024
4eb6322
Update no-xfail-without-tracker.cpp
lbushi25 Dec 18, 2024
31da9a2
Update no-xfail-without-tracker.cpp
lbushi25 Dec 18, 2024
9b22902
Fix formatting
lbushi25 Dec 18, 2024
e256ed5
Add XFAIL tracker to assert-windows.cpp
lbushi25 Dec 19, 2024
4274839
Update no-xfail-without-tracker.cpp
lbushi25 Dec 19, 2024
1368b91
Modify logic in counting of improperly XFAIL-ed tests
lbushi25 Dec 19, 2024
6320e53
Modify logic in counting of improperly XFAIL-ed tests
lbushi25 Dec 19, 2024
503a86b
Use not instead of ! to negate result
lbushi25 Dec 19, 2024
4dc01a2
Formatting
lbushi25 Dec 19, 2024
256cedf
Merge branch 'sycl' into add_trackers_XFAIL
lbushi25 Dec 20, 2024
3f21c92
Replace JIRA tracker with GH issue for throw-exception-for-out-of-reg…
lbushi25 Dec 24, 2024
03ba235
Remove XFAIL from assert-windows.cpp
lbushi25 Dec 27, 2024
efa5f4e
Merge branch 'intel:sycl' into add_trackers_XFAIL
lbushi25 Jan 2, 2025
023d26b
Replace <assert.h> with <cassert> in device-windows.cpp
lbushi25 Jan 2, 2025
83163c6
Update assert-windows.cpp to add tracker for new-found issue
lbushi25 Jan 2, 2025
297d9a8
Update assert-windows.cpp
lbushi25 Jan 2, 2025
dc95bfb
Merge branch 'sycl' into add_trackers_XFAIL
lbushi25 Jan 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

// FIXME: There's an issue in gfx driver, so this test pending here.
// XFAIL: run-mode
// XFAIL-TRACKER: GSD-9911
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I heard that we shouldn't use JIRA to track issues in syclos, am I right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we are allowed to put JIRA numbers but not JIRA links.


#include <sycl/detail/core.hpp>
#include <sycl/ext/oneapi/experimental/address_cast.hpp>
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/Basic/max_linear_work_group_size_props.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

// This property is not yet supported by all UR adapters
// XFAIL: level_zero, opencl, hip
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16403

#include <sycl/detail/core.hpp>

Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/Basic/max_work_group_size_props.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

// This property is not yet supported by all UR adapters
// XFAIL: level_zero, opencl, hip
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16403

#include <sycl/detail/core.hpp>

Expand Down
3 changes: 1 addition & 2 deletions sycl/test-e2e/DeviceLib/assert-windows.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
// REQUIRES: cpu,windows
//
// FIXME: OpenCL CPU backend compiler crashes on a call to _wassert.
// Disable the test until the fix reaches SYCL test infrastructure.
// XFAIL: *
KornevNikita marked this conversation as resolved.
Show resolved Hide resolved
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16507
//
// RUN: %{build} -o %t.out
//
Expand Down
1 change: 0 additions & 1 deletion sycl/test-e2e/ESIMD/hardware_dispatch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
// XFAIL: igc-dev
// REQUIRES: ocloc && arch-intel_gpu_tgllp
// RUN: %clangxx -fsycl -fsycl-targets=intel_gpu_tgllp %s -o %t.out
// RUN: %{run-unfiltered-devices} %t.out
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/InlineAsm/asm_multiple_instructions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
// The test is failing when writing directly to output buffer.
// If temporary variable is used (see TO_PASS mode) the test succeeded.
// XFAIL: gpu && run-mode
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16412
#include "include/asmhelper.h"
#include <iostream>
#include <vector>
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/NewOffloadDriver/multisource.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
//
//===----------------------------------------------------------------------===//
// XFAIL: cuda
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16413
// Separate kernel sources and host code sources
// Test with `--offload-new-driver`
// RUN: %{build} --offload-new-driver -c -o %t.kernel.o -DINIT_KERNEL -DCALC_KERNEL
Expand Down
3 changes: 2 additions & 1 deletion sycl/test-e2e/NewOffloadDriver/split-per-source-main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
// RUN: --offload-new-driver -fsycl-dead-args-optimization
// RUN: %{run} %t.out
//
// XFAIL: hip_nvidia, cuda
// XFAIL: cuda
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16413

#include "Inputs/split-per-source.h"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
// RUN: %clangxx -Wno-error=unused-command-line-argument -fsycl -fsycl-targets=%{sycl_triple} --offload-new-driver %t1.o %t2.o -o %t.exe
// RUN: %{run} %t.exe
// XFAIL: cuda
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16413

#ifdef SOURCE1
#include <iostream>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
// XFAIL: *
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/12679

#include <numeric>
#include <string_view>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// XFAIL: native_cpu
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16415
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out

Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/Reduction/reduction_big_data.cpp
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//
// Group algorithms are not supported on Nvidia.
// XFAIL: hip_nvidia
//

// Windows doesn't yet have full shutdown().
// UNSUPPORTED: ze_debug && windows
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/Reduction/reduction_nd_reducer_skip.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//
// Group algorithms are not supported on Nvidia.
// XFAIL: hip_nvidia

// Windows doesn't yet have full shutdown().
// UNSUPPORTED: ze_debug && windows
Expand Down
3 changes: 0 additions & 3 deletions sycl/test-e2e/Reduction/reduction_reducer_op_eq.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
//
// On nvidia a reduction appears to be unexpectedly executed via the host.
// XFAIL: hip_nvidia

// Windows doesn't yet have full shutdown().
// UNSUPPORTED: ze_debug && windows
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/Regression/build_log.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
// CHECK-EXPECTED-ERROR: error: backend compiler failed build

// XFAIL: *
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16416

#include <stdio.h>
#include <sycl/detail/core.hpp>
Expand Down
1 change: 0 additions & 1 deletion sycl/test-e2e/Regression/complex_global_object.cpp
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
// XFAIL: gpu && linux

// SYCL runtime may construct global objects at function scope. The test ensures
// such objects do not cause problems if the first call to SYCL is inside main
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// RUN: %{run} %t.out
//
// XFAIL: cuda
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16417
// UNSUPPORTED: hip

// Windows doesn't yet have full shutdown().
Expand Down
1 change: 1 addition & 0 deletions sycl/test-e2e/Regression/reduction_resource_leak_dw.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// REQUIRES: level_zero, level_zero_dev_kit
// XFAIL: windows
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/16418
//
// RUN: %{build} %level_zero_options -o %t.out
// RUN: %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s
Expand Down
52 changes: 5 additions & 47 deletions sycl/test/e2e_test_requirements/no-xfail-without-tracker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,57 +20,15 @@
// - in the result, search for "XFAIL" again, but invert the result - this
// allows us to get the line *after* XFAIL
// - in those lines, check that XFAIL-TRACKER is present and correct. Once
// again, invert the search to get all "bad" lines and save the test names in
// the temp file
// - make a final count of how many ill-formatted directives there are and
// verify that against the reference
// - ...and check if the list of improperly XFAIL-ed tests needs to be updated.
// again, invert the search to get all "bad" lines. Because there should be no
// bad lines, check that the search fails using the negation operator not.
//
// RUN: grep -rI "XFAIL:" %S/../../test-e2e \
// RUN: -A 1 --include=*.cpp --no-group-separator | \
// RUN: grep -v "XFAIL:" | \
// RUN: grep -Pv "(?:XFAIL-TRACKER:\s+(?:(?:https:\/\/github.com\/[\w\d-]+\/[\w\d-]+\/issues\/[\d]+)|(?:[\w]+-[\d]+)))" > %t
// RUN: cat %t | wc -l | FileCheck %s --check-prefix NUMBER-OF-XFAIL-WITHOUT-TRACKER
// RUN: cat %t | sed 's/\.cpp.*/.cpp/' | sort | FileCheck %s
//
// The number below is a number of tests which are *improperly* XFAIL-ed, i.e.
// we either don't have a tracker associated with a failure listed in those
// tests, or it is listed in a wrong format.
// Note: strictly speaking, that is not amount of files, but amount of XFAIL
// directives. If a test contains several XFAIL directives, some of them may be
// valid and other may not.
//
// That number *must not* increase. Any PR which causes this number to grow
// should be rejected and it should be updated to either keep the number as-is
// or have it reduced (preferably, down to zero).
// RUN: not grep -Pv "XFAIL-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)"
//
// If you see this test failed for your patch, it means that you either
// introduced XFAIL directive to a test improperly, or broke the format of an
// existing XFAIL-ed tests.
// Another possibility (and that is a good option) is that you updated some
// tests to match the required format and in that case you should just update
// (i.e. reduce) the number and the list below.
//
// NUMBER-OF-XFAIL-WITHOUT-TRACKER: 18
//
// List of improperly XFAIL-ed tests.
// Remove the CHECK once the test has been properly XFAIL-ed.
//
// CHECK: AddressSanitizer/nullpointer/private_nullptr.cpp
// CHECK-NEXT: Basic/max_linear_work_group_size_props.cpp
// CHECK-NEXT: Basic/max_work_group_size_props.cpp
// CHECK-NEXT: DeviceLib/assert-windows.cpp
// CHECK-NEXT: ESIMD/hardware_dispatch.cpp
// CHECK-NEXT: InlineAsm/asm_multiple_instructions.cpp
// CHECK-NEXT: NewOffloadDriver/multisource.cpp
// CHECK-NEXT: NewOffloadDriver/split-per-source-main.cpp
// CHECK-NEXT: NewOffloadDriver/sycl-external-with-optional-features.cpp
// CHECK-NEXT: OptionalKernelFeatures/throw-exception-for-out-of-registers-on-kernel-launch.cpp
// CHECK-NEXT: PerformanceTests/Reduction/reduce_over_sub_group.cpp
// CHECK-NEXT: Reduction/reduction_big_data.cpp
// CHECK-NEXT: Reduction/reduction_nd_reducer_skip.cpp
// CHECK-NEXT: Reduction/reduction_reducer_op_eq.cpp
// CHECK-NEXT: Regression/build_log.cpp
// CHECK-NEXT: Regression/complex_global_object.cpp
// CHECK-NEXT: Regression/kernel_bundle_ignore_sycl_external.cpp
// CHECK-NEXT: Regression/reduction_resource_leak_dw.cpp
// existing XFAIL-ed tests. Note in particular that XFAIL-TRACKER should appear in the
// next line following the XFAIL.
Loading