Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Add XFAIL trackers for improperly XFAIL-ed E2E tests #16421

Merged
merged 52 commits into from
Jan 3, 2025

Conversation

lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Dec 18, 2024

Add XFAIL trackers for improperly XFAIL-ed E2E tests. This brings the number of improperly XFAIL-ed tests down to zero.
For the tests below, the XFAILs have been removed entirely.

  • For sycl/test-e2e/ESIMD/hardware_dispatch.cpp, the XFAIL is on igc-dev but the test requires GEN12 which does not have igc-dev so this XFAIL is meaningless. Thanks to @sarnex for noting this.

  • Three tests under test-e2e/Reduction which are XFAIL-ed only on hip_nvidia which we do not support anymore.

Closes: #16400

@lbushi25
Copy link
Contributor Author

Failure is unrelated. I believe it will be handled by #16452

@lbushi25
Copy link
Contributor Author

@intel/llvm-reviewers-runtime friendly ping

@@ -2,6 +2,7 @@
// RUN: %{build} -o %t.out
// RUN: %{run} %t.out
// XFAIL: *
// XFAIL-TRACKER: CMPLRTST-24904
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it #12679 ?

Copy link
Contributor Author

@lbushi25 lbushi25 Dec 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I forgot to do a search for this.
It has been changed now.

@lbushi25
Copy link
Contributor Author

lbushi25 commented Jan 3, 2025

@intel/llvm-gatekeepers This should be ready to merge.

@sarnex sarnex merged commit faf93d5 into intel:sycl Jan 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test ESIMD/hardware_dispatch.cpp is marked as XFAIL on dev-igc on
5 participants