Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update medium job to run as PR check #318

Merged
merged 1 commit into from
Oct 22, 2024
Merged

ci: update medium job to run as PR check #318

merged 1 commit into from
Oct 22, 2024

Conversation

nathan-weinberg
Copy link
Member

@nathan-weinberg nathan-weinberg commented Oct 21, 2024 •
edited
Loading

Integration test to ensure compatibility for full SDG runs

@mergify mergify bot added the CI/CD Affects CI/CD configuration label Oct 21, 2024
@nathan-weinberg nathan-weinberg force-pushed the med-e2e-new branch 2 times, most recently from 751fe29 to 1d6a6ba Compare October 22, 2024 03:05
@mergify mergify bot added the documentation Improvements or additions to documentation label Oct 22, 2024
@nathan-weinberg nathan-weinberg requested a review from a team October 22, 2024 03:08
@nathan-weinberg nathan-weinberg marked this pull request as ready for review October 22, 2024 03:08
bbrowning
bbrowning approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@bbrowning bbrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for adding a test for the full pipeline!

@mergify mergify bot added the one-approval label Oct 22, 2024
@mergify mergify bot merged commit dcb584f into instructlab:main Oct 22, 2024
9 checks passed
@mergify mergify bot removed the one-approval label Oct 22, 2024
@bbrowning
Copy link
Contributor

I see the new medium job failed after merging - https://github.com/instructlab/sdg/actions/runs/11460182115 - it's not entirely clear what went wrong to me at first glance, but it looks like ilab model list was not happy during testing. Maybe an issue downloading model weights? Will have to dig in more.

@nathan-weinberg nathan-weinberg deleted the med-e2e-new branch October 22, 2024 15:03
@nathan-weinberg
Copy link
Member Author

I know the issue @bbrowning - we need an HF_TOKEN for the downloads - I will fix

@nathan-weinberg nathan-weinberg mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaledsulayman khaledsulayman khaledsulayman approved these changes

@bbrowning bbrowning bbrowning approved these changes

Assignees
No one assigned
Labels
CI/CD Affects CI/CD configuration documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathan-weinberg @bbrowning @khaledsulayman