Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: medium E2E CI job was missing HF_TOKEN #319

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

nathan-weinberg
Copy link
Member

Followup on #318

@nathan-weinberg nathan-weinberg marked this pull request as ready for review October 22, 2024 15:08
@nathan-weinberg
Copy link
Member Author

Medium will fail on this PR since the change won't take effect until merge

@mergify mergify bot added CI/CD Affects CI/CD configuration ci-failure labels Oct 22, 2024
@mergify mergify bot added the one-approval label Oct 22, 2024
@nathan-weinberg
Copy link
Member Author

Merging to get this fix in

@nathan-weinberg nathan-weinberg merged commit c5b50f0 into instructlab:main Oct 22, 2024
9 of 10 checks passed
@nathan-weinberg nathan-weinberg deleted the fix-med branch October 22, 2024 21:58
@bbrowning
Copy link
Contributor

I spot-checked the post-merge job and verified this fixes it - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Affects CI/CD configuration ci-failure one-approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants