Explorer add gc and confirmed block notion #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecioppettini
added
bug
| @@ -43,12 +43,9 @@ impl<T: Clone> Multiverse<T> { | |||
| } | |||
| } | |||
|
|
|||
| impl Multiverse<Ledger> { | |||
| impl<T> Multiverse<T> { | |||
There was a problem hiding this comment.
Huh? I was pretty sure I already did that.
There was a problem hiding this comment.
Hmmm, probably you did it the same with the actual multiverse in chain-libs
eugene-babichenko
approved these changes
Feb 4, 2021
| .chain_length() | ||
| .nth_ancestor(self.blockchain_config.epoch_stability_depth) | ||
| { | ||
| debug_assert!( |
There was a problem hiding this comment.
Why not just assert!? Might be difficult to track problems in production.
There was a problem hiding this comment.
Well, I just thought debug_assert was paranoid enough, and I wanted to write the invariant in some way at least. I don't really mind using assert anyway, but if this actually happens it is most likely a programmer error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the notion of
epoch_stability_depthto the explorer. It's used both for multiverse garbage collection and to know if a block is confirmed.Also, when working on this I found a problem with the way tip changes were handled in #2903
The thing is, tip changes are being sent to the explorer before having the block. This means, that we can't get the State at that particular hash, so we don't have the block and we can't know it's chain_length to find out which one is confirmed.
Also means that a query may come in the middle and try to use a branch not fully indexed and break things like @dkijania also found in #2950
This PR fixes it in a way that may be a bit hacky. It works by saving the tip update for the time the block comes, if it's not already there, so it doesn't care which one comes first.
A proper solution could be to send blocks to the explorer after knowing the branch solution result, but the problem is that by that point the node only has a
Refand not aBlock, so that would require either carrying the block there, or sending the branch comparison result back (up in the stack trace).An alternative could be to only send hashes, and get blocks from the storage, but I think this is blocking? and maybe not fast.