Add tracking tips explorer multiverse #2981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene-babichenko
approved these changes
Feb 4, 2021
| display("the explorer's database couldn't be initialized: {}", msg) | ||
| } | ||
| } | ||
| #[derive(Debug, Error)] |
There was a problem hiding this comment.
Woohoo, removing last error_chain pieces!
ecioppettini
force-pushed
the
add-tracking-tips-explorer-multiverse
branch
from
038a68b to
f985ae4
Compare
although unlikely, it may report false positives otherwise also, it's probably a bit more efficient
|
The nightly failure is resolved in #2995. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intermediate step, see #2963
This essentially changes the explorer backend/indexing, but without adding the breaking changes to graphql.
This may conflict with #2962, it's not really dependent, but it touches the same things. I would merge #2962 first anyway, so maybe I'll rebase this one on top.
Backend
State, so theExplorerDBcan be used likeget_branch(hash)orget_main_branch(hash). Also, change the graphql queries so they useget_main_branch, so this PR still retains most of the current behaviour.GraphQL API
The changes to the
graphql/mod.rsare only to make things still compile, most queries keep the current behavior except forbreaking changes will come in the next PR.