Skip to content

Commit

Permalink
Leftover docs
Browse files Browse the repository at this point in the history
  • Loading branch information
iquerejeta committed Dec 20, 2024
1 parent ddcb294 commit 1e2a10a
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
1 change: 0 additions & 1 deletion src/plonk/vanishing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ mod prover;
mod verifier;

/// A vanishing argument.
/// todo: do we need to have the PCS here?
pub(crate) struct Argument<F: PrimeField, CS: PolynomialCommitmentScheme<F>> {
_marker: PhantomData<(F, CS)>,
}
1 change: 0 additions & 1 deletion src/poly/commitment.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ pub trait PolynomialCommitmentScheme<F: PrimeField>: Clone + Debug {
fn commit(params: &Self::Parameters, polynomial: &Polynomial<F, Coeff>) -> Self::Commitment;

/// Create an opening proof at a specific query
/// FIXME: We are not writing the queries to the transcript
fn open<'com, T: Transcript, I>(
params: &Self::Parameters,
prover_query: I,
Expand Down
8 changes: 0 additions & 8 deletions src/transcript/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,9 @@ use std::io::{self, Cursor};
/// Prefix to a prover's message soliciting a challenge
const BLAKE2B_PREFIX_CHALLENGE: u8 = 0;

// TODO: BEFORE WE HAD DIFFERENT PREFIXES FOR DIFFERENT TYPES
/// Prefix to a prover's message
const BLAKE2B_PREFIX_COMMON: u8 = 1;

/*
/// NOTE /////
Why do we need the below three traits? The reason is that we cannot implement
Into<Transcript::HashInput> for an arbitrary type due to the orphan rule. This
means that we need to have a trait for something that is hashable.
*/

/// Hash function that can be used for transcript
pub trait TranscriptHash {
/// Input type of the hash function
Expand Down

0 comments on commit 1e2a10a

Please sign in to comment.