Address review comments

input-output-hk · Dec 19, 2024 · ddcb294 · ddcb294
1 parent 428128c
commit ddcb294
Show file tree

Hide file tree

Showing 28 changed files with 684 additions and 1,064 deletions.
diff --git a/benches/plonk.rs b/benches/plonk.rs
@@ -12,8 +12,8 @@ use std::marker::PhantomData;
 
 use criterion::{BenchmarkId, Criterion};
 use halo2_proofs::poly::kzg::{params::ParamsKZG, KZGCommitmentScheme};
-use halo2_proofs::utils::rational::Rational;
 use halo2_proofs::transcript::{CircuitTranscript, Transcript};
+use halo2_proofs::utils::rational::Rational;
 
 fn criterion_benchmark(c: &mut Criterion) {
     /// This represents an advice column at a certain row in the ConstraintSystem

diff --git a/examples/proof-size.rs b/examples/proof-size.rs
@@ -88,7 +88,7 @@ const K: u32 = 11;
 fn main() {
     let circuit = TestCircuit {};
 
-    let model = from_circuit_to_model_circuit::<_, _, 56, 56>(
+    let model = from_circuit_to_model_circuit::<_, _, 32, 32>(
         Some(K),
         &circuit,
         vec![],

diff --git a/examples/shuffle.rs b/examples/shuffle.rs
diff --git a/examples/simple-example.rs b/examples/simple-example.rs
@@ -1,10 +1,10 @@
 use std::marker::PhantomData;
 
 use halo2_proofs::{
-    utils::arithmetic::Field,
     circuit::{AssignedCell, Chip, Layouter, Region, SimpleFloorPlanner, Value},
     plonk::{Advice, Circuit, Column, ConstraintSystem, Error, Fixed, Instance, Selector},
     poly::Rotation,
+    utils::arithmetic::Field,
 };
 
 // ANCHOR: instructions

diff --git a/examples/two-chip.rs b/examples/two-chip.rs
@@ -1,10 +1,10 @@
 use std::marker::PhantomData;
 
 use halo2_proofs::{
-    utils::arithmetic::Field,
     circuit::{AssignedCell, Chip, Layouter, Region, SimpleFloorPlanner, Value},
     plonk::{Advice, Circuit, Column, ConstraintSystem, Error, Instance, Selector},
     poly::Rotation,
+    utils::arithmetic::Field,
 };
 
 // ANCHOR: field-instructions