Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: naming mismatch #1349

Merged
merged 2 commits into from
Dec 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions catalyst-gateway/bin/src/db/index/block/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,10 @@ pub(crate) async fn index_block(block: &MultiEraBlock) -> anyhow::Result<()> {
}
match handle.await {
Ok(join_res) => {
match join_res {
Ok(_res) => {}, // debug!(res=?res,"Query OK")
Err(error) => {
// IF a query fails, assume everything else is broken.
error!(error=%error,"Query Failed");
result = Err(error);
},
if let Err(error) = join_res {
// IF a query fails, assume everything else is broken.
error!(error=%error,"Query Failed");
result = Err(error);
}
},
Err(error) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const INSERT_CHAIN_ROOT_FOR_STAKE_ADDRESS_QUERY: &str =
#[derive(SerializeRow)]
pub(super) struct Params {
/// Stake Address Hash. 32 bytes.
stake_address: Vec<u8>,
stake_addr: Vec<u8>,
/// Block Slot Number
slot_no: num_bigint::BigInt,
/// Transaction Offset inside the block.
Expand All @@ -29,7 +29,7 @@ pub(super) struct Params {
impl Debug for Params {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
f.debug_struct("Params")
.field("stake_address", &self.stake_address)
.field("stake_addr", &self.stake_addr)
.field("slot_no", &self.slot_no)
.field("txn", &self.txn)
.field("chain_root", &self.chain_root)
Expand All @@ -39,9 +39,9 @@ impl Debug for Params {

impl Params {
/// Create a new record for this transaction.
pub(super) fn new(stake_address: &[u8], chain_root: &[u8], slot_no: u64, txn: i16) -> Self {
pub(super) fn new(stake_addr: &[u8], chain_root: &[u8], slot_no: u64, txn: i16) -> Self {
Params {
stake_address: stake_address.to_vec(),
stake_addr: stake_addr.to_vec(),
slot_no: num_bigint::BigInt::from(slot_no),
txn,
chain_root: chain_root.to_vec(),
Expand Down
24 changes: 17 additions & 7 deletions catalyst-gateway/bin/src/db/index/queries/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ pub(crate) mod sync_status;

use std::{fmt::Debug, sync::Arc};

use anyhow::{bail, Context};
use anyhow::bail;
use crossbeam_skiplist::SkipMap;
use rbac::{
get_chain_root::GetChainRootQuery, get_registrations::GetRegistrationsByChainRootQuery,
Expand All @@ -29,6 +29,7 @@ use staked_ada::{
get_txo_by_stake_address::GetTxoByStakeAddressQuery, update_txo_spent::UpdateTxoSpentQuery,
};
use sync_status::update::SyncStatusInsertQuery;
use tracing::error;

use super::block::{
certs::CertInsertQuery, cip36::Cip36InsertQuery, rbac509::Rbac509InsertQuery,
Expand Down Expand Up @@ -379,6 +380,8 @@ impl PreparedQueries {
let mut results: Vec<QueryResult> = Vec::new();

let chunks = values.chunks(cfg.max_batch_size.try_into().unwrap_or(1));
let mut query_failed = false;
let query_str = format!("{query}");

for chunk in chunks {
let chunk_size: u16 = chunk.len().try_into()?;
Expand All @@ -387,12 +390,19 @@ impl PreparedQueries {
bail!("No batch query found for size {}", chunk_size);
};
let batch_query_statements = batch_query.value().clone();
results.push(
session
.batch(&batch_query_statements, chunk)
.await
.context(format!("query={query}, chunk={chunk:?}"))?,
);
match session.batch(&batch_query_statements, chunk).await {
Ok(result) => results.push(result),
Err(err) => {
let chunk_str = format!("{chunk:?}");
error!(error=%err, query=query_str, chunk=chunk_str, "Query Execution Failed");
query_failed = true;
// Defer failure until all batches have been processed.
},
}
}

if query_failed {
bail!("Query Failed: {query_str}!");
}

Ok(results)
Expand Down
Loading