Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: naming mismatch #1349

Merged
merged 2 commits into from
Dec 6, 2024
Merged

fix: naming mismatch #1349

merged 2 commits into from
Dec 6, 2024

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Dec 6, 2024

Description

Thanks for contributing to the project!
Please fill out this template to help us review your changes.

Related Issue(s)

List the issue numbers related to this pull request.

e.g., Closes #1, Resolves #1 Fixes #1

Description of Changes

Provide a clear and concise description of what the pull request changes.

Breaking Changes

Describe any breaking changes and the impact.

Screenshots

If applicable, add screenshots to help explain your changes.

Related Pull Requests

If applicable, list any related pull requests.

e.g., #1, #1

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Signed-off-by: bkioshn <[email protected]>
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Test Report | ${\color{lightgreen}Pass: 334/334}$ | ${\color{red}Fail: 0/334}$ |

@stevenj stevenj self-assigned this Dec 6, 2024
@stevenj stevenj marked this pull request as draft December 6, 2024 14:02
@stevenj stevenj added do not merge yet PR is not ready to be merged yet do not review yet Do not review yet labels Dec 6, 2024
@stevenj stevenj marked this pull request as ready for review December 6, 2024 14:04
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 9810f16 into main Dec 6, 2024
38 checks passed
@stevenj stevenj deleted the fix/db-indexer branch December 6, 2024 14:04
@stevenj stevenj removed do not merge yet PR is not ready to be merged yet do not review yet Do not review yet labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

First
2 participants