Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(general): add running allure report flow after forge ci job #1006

Conversation

oldGreg5
Copy link
Contributor

@oldGreg5 oldGreg5 commented Oct 16, 2024

Description

Set allure workflow to run during CI job, and make allure use forge instead of ci actions

Related Issue(s)

Implements #974

Description of Changes

This is first PR that sets allure workflow to be callable from ci workflow.
After changes are in main second PR will add calling allure workflow during ci after ci job finishes

Breaking Changes

Screenshots

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Test Report | ${\color{lightgreen}Pass: 292/292}$ | ${\color{red}Fail: 0/292}$ |

@oldGreg5 oldGreg5 changed the title add running allure report flow after forge ci job refactor(ci): add running allure report flow after forge ci job Oct 16, 2024
@oldGreg5 oldGreg5 changed the title refactor(ci): add running allure report flow after forge ci job refactor(general): add running allure report flow after forge ci job Oct 16, 2024
@oldGreg5 oldGreg5 marked this pull request as ready for review October 16, 2024 06:53
@oldGreg5 oldGreg5 marked this pull request as draft October 16, 2024 06:54
@oldGreg5 oldGreg5 marked this pull request as ready for review October 17, 2024 09:34
@oldGreg5 oldGreg5 requested a review from kukkok3 October 17, 2024 09:41
@oldGreg5 oldGreg5 requested a review from kukkok3 October 17, 2024 10:41
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 merged commit b20c6f9 into main Oct 17, 2024
31 checks passed
@kukkok3 kukkok3 deleted the 974-task-make-the-allure-report-workflow-run-after-the-normal-ci-run branch October 17, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Make the allure report workflow run after the normal CI run
2 participants