fix: refactor(rm spending counter): audit tooling | NPG-000

src/chain-libs/chain-impl-mockchain/src/accounting/account/spending.rs

@@ -58,35 +58,14 @@ impl SpendingCounterIncreasing {
     /// an error reported.
     ///
     /// If the counter match succesfully, then the counter at this lane is incremented by one.
-    pub fn next_verify(&mut self, counter: SpendingCounter) -> Result<(), Error> {
-        let actual_counter = self.nexts[counter.lane()];
-
-        if actual_counter != counter {
-            Err(Error::SpendingCredentialInvalid {
-                expected: actual_counter,
-                actual: counter,
-            })
-        } else {
-            self.next_unchecked(counter);
-            Ok(())
-        }
+    pub fn next_verify(&mut self, _counter: SpendingCounter) -> Result<(), Error> {
+        // spending counter logic has been removed throughout, returning OK is the least invasive action at the moment.
+        // Prod chain-libs = https://github.com/input-output-hk/chain-libs/tree/catalyst-fund9-gold
+        Ok(())
     }
 
     /// Increases the spending counter on the given lane.
-    pub(crate) fn next_unchecked(&mut self, unchecked_counter: SpendingCounter) {
-        let lane = unchecked_counter.lane();
-        let counter_to_update = self.nexts[lane];
-        if counter_to_update != unchecked_counter {
-            tracing::warn!(
-                "Invalid spending counter, {}",
-                Error::SpendingCredentialInvalid {
-                    expected: counter_to_update,
-                    actual: unchecked_counter,
-                }
-            );
-        }
-        self.nexts[lane] = counter_to_update.increment();
-    }
+    pub(crate) fn next_unchecked(&mut self, _unchecked_counter: SpendingCounter) {}
 }
 
 // only used to print the account's ledger

src/chain-libs/chain-impl-mockchain/src/ledger/tests/transaction_tests.rs

@@ -97,6 +97,7 @@ pub fn transaction_nonexisting_account_input() {
 }
 
 #[test]
+#[ignore]
 pub fn transaction_with_incorrect_account_spending_counter() {
     let faucet =
         AddressDataValue::account_with_spending_counter(Discrimination::Test, 1, Value(1000));

src/chain-libs/chain-impl-mockchain/src/testing/e2e/mod.rs

@@ -4,7 +4,6 @@ pub mod mint_token;
 pub mod owner_delegation;
 pub mod pool_update;
 pub mod rewards;
-pub mod spending_counter_lanes;
 pub mod stake_distribution;
 pub mod transactions;
 pub mod update_proposal;

src/jormungandr/testing/jormungandr-integration-tests/src/jormungandr/mempool.rs

@@ -352,6 +352,7 @@ pub fn pending_fragment_should_be_persisted() {
 }
 
 #[test]
+#[ignore]
 pub fn node_should_pickup_log_after_restart() {
     let mut temp_dir = TempDir::new().unwrap();
     let dump_folder = temp_dir.child("dump_folder");