fix: refactor(rm spending counter): audit tooling | NPG-000 #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cong-or
changed the title
kukkok3
reviewed
Jan 24, 2024
| @@ -58,35 +58,12 @@ impl SpendingCounterIncreasing { | |||
| /// an error reported. | |||
| /// | |||
| /// If the counter match succesfully, then the counter at this lane is incremented by one. | |||
| pub fn next_verify(&mut self, counter: SpendingCounter) -> Result<(), Error> { | |||
There was a problem hiding this comment.
Maybe make explicit in the comment why this function it just returns Ok() ?
kukkok3
previously approved these changes
Jan 24, 2024
This reverts commit a14b1ae.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT PRODUCTION CODE
The following is our production chain-libs
We have removed spending counter logic long ago due to inherent flaws in the context of correctness. Audit tooling on cat core needs to reflect this to perform a correct offline tally without errors hence removing the checks.