CI 2.0 - unified CI for C++, Go and RUST - PHASE1 #680
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,91 @@ | ||
| // use std::env; | ||
| // use std::path::PathBuf; | ||
|
There was a problem hiding this comment. please remove commented code |
||
|
|
||
| // fn main() { | ||
| // // Retrieve environment variables | ||
|
There was a problem hiding this comment. what about the rest of the curves/fields? There was a problem hiding this comment. 761 was the only curve using a build that relies on another curve bls12-377 (probably due to legacy code). so only 761 needs that update. new build script was tested and is running on the new CI |
||
| // let out_dir = env::var("OUT_DIR").expect("OUT_DIR is not set"); | ||
|
|
||
| // // Construct the path to the build directory | ||
| // let build_dir = PathBuf::from(format!("{}/../../../", &out_dir)); | ||
|
|
||
| // // Construct the path to the deps directory | ||
| // let deps_dir = build_dir.join("deps"); | ||
|
|
||
| // println!("cargo:rustc-link-arg=-Wl,-rpath,{}/icicle/lib", deps_dir.display()); // Add RPATH linker arguments | ||
|
|
||
| // // default backends dir | ||
| // if cfg!(feature = "cuda_backend") || cfg!(feature = "pull_cuda_backend") { | ||
| // println!( | ||
| // "cargo:rustc-env=ICICLE_BACKEND_INSTALL_DIR={}/icicle/lib/backend", | ||
| // deps_dir.display() | ||
| // ); | ||
| // } | ||
| // } | ||
|
|
||
| use cmake::Config; | ||
| use std::{env, path::PathBuf}; | ||
|
|
||
| fn main() { | ||
| // Construct the path to the deps directory | ||
| let out_dir = env::var("OUT_DIR").expect("OUT_DIR is not set"); | ||
| let build_dir = PathBuf::from(format!("{}/../../../", &out_dir)); | ||
| let deps_dir = build_dir.join("deps"); | ||
|
|
||
| // Construct the path to icicle source directory | ||
| let main_dir = env::current_dir().expect("Failed to get current directory"); | ||
| let icicle_src_dir = PathBuf::from(format!("{}/../../../../icicle", main_dir.display())); | ||
|
|
||
| println!("cargo:rerun-if-env-changed=CXXFLAGS"); | ||
| println!("cargo:rerun-if-changed={}", icicle_src_dir.display()); | ||
|
|
||
| // Base config | ||
| let mut config = Config::new(format!("{}", icicle_src_dir.display())); | ||
| // Check if ICICLE_INSTALL_DIR is defined | ||
| let icicle_install_dir = if let Ok(dir) = env::var("ICICLE_INSTALL_DIR") { | ||
| PathBuf::from(dir) | ||
| } else { | ||
| // Define the default install directory to be under the build directory | ||
| PathBuf::from(format!("{}/icicle/", deps_dir.display())) | ||
| }; | ||
| config | ||
| .define("CURVE", "bw6_761") | ||
| .define("HASH", "OFF") | ||
| .define("CMAKE_INSTALL_PREFIX", &icicle_install_dir); | ||
|
|
||
| // build (or pull and build) cuda backend if feature enabled. | ||
| // Note: this requires access to the repo | ||
| if cfg!(feature = "cuda_backend") { | ||
| config.define("CUDA_BACKEND", "local"); | ||
| } else if cfg!(feature = "pull_cuda_backend") { | ||
| config.define("CUDA_BACKEND", "main"); | ||
| } | ||
| if cfg!(feature = "metal_backend") { | ||
| config.define("METAL_BACKEND", "local"); | ||
| } else if cfg!(feature = "pull_metal_backend") { | ||
| config.define("METAL_BACKEND", "main"); | ||
| } | ||
|
|
||
| // Build | ||
| let _ = config | ||
| .build_target("install") | ||
| .build(); | ||
|
|
||
| println!("cargo:rustc-link-search={}/lib", icicle_install_dir.display()); | ||
| println!("cargo:rustc-link-lib=icicle_field_bw6_761"); | ||
| println!("cargo:rustc-link-lib=icicle_curve_bw6_761"); | ||
| println!("cargo:rustc-link-lib=icicle_hash"); | ||
| println!("cargo:rustc-link-arg=-Wl,-rpath,{}/lib", icicle_install_dir.display()); // Add RPATH linker arguments | ||
|
|
||
| // default backends dir | ||
| // default backends dir | ||
|
|
||
| if cfg!(feature = "cuda_backend") | ||
| || cfg!(feature = "pull_cuda_backend") | ||
| || cfg!(feature = "metal_backend") | ||
| || cfg!(feature = "pull_metal_backend") | ||
| { | ||
| println!( | ||
| "cargo:rustc-env=ICICLE_BACKEND_INSTALL_DIR={}/lib/backend", | ||
| icicle_install_dir.display() | ||
| ); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is that commented out?
We still support 761
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
761 got a standalone build.rs and no longer relies on bls12-377. I will remove the comments