CI 2.0 - unified CI for C++, Go and RUST - PHASE1 #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviadingo
changed the title
aviadingo
requested review from
yshekel,
jeremyfelder,
mickeyasa and
LeonHibnik
mickeyasa
approved these changes
Dec 23, 2024
| .define("FIELD", "bw6_761") | ||
| .define("HASH", "OFF") | ||
| .define("CMAKE_INSTALL_PREFIX", &icicle_install_dir); | ||
| // if cfg!(feature = "bw6-761") { |
There was a problem hiding this comment.
why is that commented out?
We still support 761
There was a problem hiding this comment.
761 got a standalone build.rs and no longer relies on bls12-377. I will remove the comments
| @@ -1,23 +1,91 @@ | |||
| use std::env; | |||
| use std::path::PathBuf; | |||
| // use std::env; | |||
There was a problem hiding this comment.
please remove commented code
| println!("cargo:rustc-link-lib=icicle_hash"); | ||
| println!("cargo:rustc-link-arg=-Wl,-rpath,{}/lib", icicle_install_dir.display()); // Add RPATH linker arguments | ||
|
|
||
| // default backends dir |
| fn main() { | ||
| // Retrieve environment variables | ||
| let out_dir = env::var("OUT_DIR").expect("OUT_DIR is not set"); | ||
| // fn main() { |
There was a problem hiding this comment.
what about the rest of the curves/fields?
There was a problem hiding this comment.
761 was the only curve using a build that relies on another curve bls12-377 (probably due to legacy code).
so only 761 needs that update. new build script was tested and is running on the new CI
LeonHibnik
approved these changes
Dec 23, 2024
| - name: bw6_761 | ||
| build_args: -DG2=ON -DECNTT=ON | ||
| - name: grumpkin | ||
| build_args: |
There was a problem hiding this comment.
minor: all features are ON by default so maybe it's better to specify explicitly such -DG2=OFF -DECNTT=OFF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
New CI combines tests for C++/GO/RUST and Examples on a single action.
Tests are divided into curves, fields and hash. each of these can run simultaniously.
Uses a precompiled version of the backend if available on the machine based on the ref to the backend, otherwise recompiles it.