Fix separate-terminal debugging #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #598 |
|
I just realized there's already one for this: #638. Seems like the challenge there had to do with ensuring that the tty file is eventually closed. I'll take a crack at it... |
MatrixManAtYrService
force-pushed
the
main
branch
from
56ac2d3
to
5b58db5
Compare
|
This looks good to me; thanks for working on it. I'll roll a release to get this out into the world. |
|
Ah! Just noticed that you've reverted this to draft; how come? |
|
Sorry for being indecisive. I had a problem which I thought might be introduced by this change, so I got paranoid and marked it as a draft with the idea that I'd use it for a while before calling it good. As it turns out, that problem was entirely separate. I used it for a while, and that worked well, but then I forgot to circle back and un-draft it. I'll do that now. |
|
Thanks! |
This was referenced Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts part of #534, which appears to have broken the ability to debug in a separate terminal (see comment there for more).
Presumably there was a reason that we wanted to close this file, but I'm not sure what that reason was. Leaving it open restored this functionality for me and nothing else bad appears to be happening 🤷 .
Maybe @inducer can suggest a better place for closing the file so that the needs of #534 are met while also not breaking separate-terminal debugging?