fix: macOS PUDB_TTY "I/O operation on closed file." #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't close a file that's in use.
Apparently linux is okay with this, but macos isn't?
Otherwise, I get this error:
```
Traceback (most recent call last):
File ".../site-packages/pudb/debugger.py", line 2542, in call_with_ui
return f(*args, **kwargs)
^^^^^^^^^^^^^^^^^^
File ".../site-packages/pudb/debugger.py", line 2865, in interaction
self.event_loop()
File ".../site-packages/pudb/debugger.py", line 2821, in event_loop
self.screen.draw_screen(self.size, canvas)
File ".../site-packages/urwid/display/_raw_display_base.py", line 582, in draw_screen
self._setup_G1()
File ".../site-packages/urwid/display/_raw_display_base.py", line 524, in _setup_G1
self.write(escape.DESIGNATE_G1_SPECIAL)
File ".../site-packages/urwid/display/_raw_display_base.py", line 220, in write
self._term_output_file.write(data)
ValueError: I/O operation on closed file.
```
inducer
reviewed
Mar 5, 2024
| @@ -80,7 +80,6 @@ def _get_debugger(**kwargs): | |||
| kwargs.setdefault("stdin", tty_file) | |||
| kwargs.setdefault("stdout", tty_file) | |||
| kwargs.setdefault("term_size", term_size) | |||
| tty_file.close() | |||
There was a problem hiding this comment.
I agree that the current state is incorrect.
Please either add a comment that we're purposefully leaking the FD, or make a way for Debugger to close the FD when done.
There was a problem hiding this comment.
I know this isn't what you mean but: The file closes when the process ends. We're doing one-time initialization of resources which will be used in the indefinite future, so it seems valid to let reference counting take care of it, to me.
I'll look and see whether I can find a better solution though.
|
Superseded by #656. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't close a file that's in use.
Apparently linux is okay with this, but macos isn't?
Otherwise, I get this error: