Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate VAM TS #36

Merged
merged 21 commits into from
Sep 18, 2024
Merged

Integrate VAM TS #36

merged 21 commits into from
Sep 18, 2024

Conversation

gkueppers
Copy link
Collaborator

@gkueppers gkueppers commented Aug 19, 2024

Adding VAM TS into etsi_its_messages

  • adapt launch.json
  • add message-package
  • add coding-package
  • add conversion package
  • run all conversions
  • integrate VAM into conversion node
  • adapt README
  • integrate VAM into gitlab- and github CI-Pipeline
  • add publish script for VAM
  • add parameter to disable asn-constraint-check before encoding of asn1 struct (check could lead to segmentation-fault because of infinte recursion)

@gkueppers gkueppers requested a review from jpbusch August 19, 2024 13:07
@gkueppers gkueppers self-assigned this Aug 19, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jpbusch
Copy link
Collaborator

jpbusch commented Aug 22, 2024

Please add a minimal example for publishing a VAM (like here). This allows us to test the encoding and decoding before merging.

@gkueppers
Copy link
Collaborator Author

Please add a minimal example for publishing a VAM (like here). This allows us to test the encoding and decoding before merging.

Currently the conversion node is crashing with a segmentation fault.
Reason for this is an infinite recursion of vam_ts_ItsPduHeaderVam_constraint in Line 26 of vam_ts_ItsPduHeaderVam.c.

It seems like there is a bug in asn1c which is may related to this issue.

@gkueppers
Copy link
Collaborator Author

Please add a minimal example for publishing a VAM (like here). This allows us to test the encoding and decoding before merging.

Currently the conversion node is crashing with a segmentation fault. Reason for this is an infinite recursion of vam_ts_ItsPduHeaderVam_constraint in Line 26 of vam_ts_ItsPduHeaderVam.c.

It seems like there is a bug in asn1c which is may related to this issue.

"Fixed" by disabling the asn-constraint check. Encoding still fails with an meaningful error-message if you try to encode an asn1-struct that does not conform to the specified asn-constraints.

etsi_its_conversion/etsi_its_conversion/src/Converter.cpp Outdated Show resolved Hide resolved
utils/scripts/README.md Outdated Show resolved Hide resolved
@gkueppers gkueppers merged commit 55384e2 into main Sep 18, 2024
32 checks passed
@gkueppers gkueppers deleted the vam-ts branch September 18, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants