-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add multiple modals example #174
add multiple modals example #174
Conversation
@genusistimelord before merging this please see issue #175 |
could you also remove the not needed comment from the documentation.. https://github.com/iced-rs/iced_aw/blob/main/src/native/modal.rs#L68 Maybe Expand this with a small explanation of how the Modal is shown or hidden since the last changes you made to it? |
4a7c574
to
627bca8
Compare
@genusistimelord please review the new PR, and let me know if everything is ok or if it should be further improved. Then I will also update the documentation comment, so please do not merge it yet. |
looks good. |
@genusistimelord, while updating the documentation comment that you pointed me out I noticed that most of the links of the
|
you can fix those too but id prefer it to be in a separate PR if you want to go though and tidy up all the documentation. |
Should I fix that single comment in this PR, and then tidy up all documentation links in another PR? |
probably if there is that much that needs to be fixed best to do it in the other PR with the rest. |
So you can go ahead merging this, and I will open a separate PR for the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good thank you.
No description provided.