-
-
Notifications
You must be signed in to change notification settings - Fork 1
chore: update dependencies in Cargo.toml and package.json for improved compatibility and performance #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d compatibility and performance
WalkthroughThis update increases the versions of several dependencies across the project. The SWC-related crates in Rust's Cargo.toml are upgraded, as well as the @rspack/cli and @rspack/core packages in two example JavaScript projects. Additionally, the @swc/core package version is bumped in the inspector plugin’s package.json, and a new changeset documents the SWC dependency bump for the @hyperse/inspector-swc-plugin package. No code or API changes are introduced. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
examples/example-rspack/package.json (1)
42-43: Prefer sem-ver range (^1.4.0) over a hard-pinned patch version.Locking to
"1.4.0"means every micro-fix will require another PR. Unless deterministic builds are required for this example project, switching to"^1.4.0"(or"~1.4.0") reduces maintenance friction while still staying on the same major.examples/example-nextjs/package.json (1)
46-47: Use a version range to avoid constant bumps.Same consideration as for the Rspack example:
"^1.4.0"keeps you on the latest patch within 1.x without manual intervention.Cargo.toml (1)
25-29: Pinned with=: consider relax to patch-compatible lock.Using
=freezes even patch updates, which include bug & CVE fixes. Switching to~28.0.0(or caret) maintains reproducibility at the minor level but allows safe patch upgrades.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
Cargo.lockis excluded by!**/*.lockyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (4)
.changeset/full-doodles-hammer.md(1 hunks)Cargo.toml(2 hunks)examples/example-nextjs/package.json(1 hunks)examples/example-rspack/package.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: deploy (20.x)
- GitHub Check: test (18.x)
- GitHub Check: test (18.x)
🔇 Additional comments (6)
examples/example-rspack/package.json (1)
42-44: Double-check cross-package compatibility.
@rspack/plugin-react-refreshremains at1.4.3while@rspack/{cli,core}are now1.4.0. The plugin occasionally trackscoreinternals; please run the demo locally to ensure there are no runtime warnings.examples/example-nextjs/package.json (1)
46-48: Validate that Turbopack still resolves@rspack/*1.4.0 correctly.Because Next 15’s Turbopack loader caches rspack binaries aggressively, clear the
.nextcache or reinstall node_modules before publishing to ensure the new versions are actually picked up.Cargo.toml (3)
27-29: 👍 Removal of the duplicateswc_configentry.The workspace now contains a single authoritative declaration, eliminating the cargo warning about duplicate deps.
41-44: Confirm feature flags match your build targets.
swc_coreis pulled withdefault-features = falseand onlyparallel_rayon. Ensure any transforms relying on, e.g.,concurrentorpluginfeatures are explicitly turned on elsewhere, otherwise runtime panics may occur at plugin load time.
24-30: ```shell
#!/bin/bashSearch Cargo.lock for swc_common entries to detect multiple versions
if [ -f Cargo.lock ]; then
rg 'name = "swc_common"' -A2 Cargo.lock
else
echo "Cargo.lock not found"
fi</details> <details> <summary>.changeset/full-doodles-hammer.md (1)</summary> `1-5`: **Changeset looks good.** Accurately documents the SWC bump for `@hyperse/inspector-swc-plugin`. No further action required. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
update swc versions
swc = { version = "=28.0.0" }
swc_config = { version = "3.1.1" }
swc_config = { version = "3.1.1" }
swc_core = { version = "=29.1.4", default-features = false, features = ["parallel_rayon"] }
swc_atoms = { version = "6.0.0" }
swc_ecma_transforms_react = { version = "20.0.0" }
swc_ecma_transforms_testing = { version = "21.0.0" }
testing = { version = "14.0.0" }
Summary by CodeRabbit