-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: publish v2.0.0 #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a changeset declaring major (v2.0.0) releases for multiple Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.changeset/lemon-words-hug.md (1)
10-12: Consider consolidating the changelog entries.The changeset contains two separate entries (feat and chore) on consecutive lines without separating blank lines between them. For clarity and readability in the final changelog, consider combining these into a single entry or adding appropriate separation.
Additionally, the chore entry ends with a semicolon, which is inconsistent with typical changelog formatting (the feat entry has none). Remove the trailing semicolon for consistency.
--- "@hyperse/inspector-babel-plugin": major "@hyperse/inspector-middleware": major "@hyperse/inspector-component": major "@hyperse/inspector-swc-plugin": major "@hyperse/inspector-common": major "@hyperse/next-inspector": major "@hyperse/inspector": major --- feat: publish v2.0.0 -chore: update dependencies across the project for improved compatibility and performance; +chore: update dependencies across the project for improved compatibility and performance
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
.changeset/lemon-words-hug.md(1 hunks)
🔇 Additional comments (1)
.changeset/lemon-words-hug.md (1)
1-9: Verify package list completeness against v2.0.0 release scope.The AI summary mentions eight packages with major version bumps, but only seven are listed in the changeset (the summary may be inaccurate). Confirm this is intentional and that all packages intended for v2.0.0 are included. If an eighth package was meant to be part of this release, add it to maintain consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.yarnrc.yml(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: github pages
.yarnrc.yml
[error] 1-1: Usage Error: Unrecognized or legacy configuration settings found: workspaces. Run 'yarn config' to see the list of settings supported in Yarn. Command 'yarn install' failed with exit code 1.
| workspaces: | ||
| packages: | ||
| - packages/* | ||
| - crates/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Invalid workspace configuration for Yarn 4.x — pipeline is failing.
The workspaces key is not a recognized configuration setting in Yarn 4.10.3 (as indicated by the pipeline failure). In Yarn v2+, workspaces are defined in package.json, not .yarnrc.yml.
After confirming the correct syntax, move the workspace configuration from .yarnrc.yml to package.json. For reference, the pipeline error was:
[error] 1-1: Usage Error: Unrecognized or legacy configuration settings found: workspaces. Run 'yarn config' to see the list of settings supported in Yarn. Command 'yarn install' failed with exit code 1.
🌐 Web query:
How to configure Yarn v4 workspaces in package.json?
💡 Result:
Short answer — in Yarn v4 you declare workspaces in the root package.json with a workspaces field (glob patterns), make the root private, optionally set packageManager, and use the workspace: protocol in workspace-to-workspace dependencies. Example:
Root package.json
{
"private": true,
"packageManager": "[email protected]",
"workspaces": [
"packages/",
"apps/"
]
}
Workspace package (packages/pkg-a/package.json)
{
"name": "@myorg/pkg-a",
"version": "1.0.0",
"main": "dist/index.js",
"dependencies": {
"lodash": "^4.17.21"
}
}
Workspace package that depends on another workspace (packages/pkg-b/package.json)
{
"name": "@myorg/pkg-b",
"version": "1.0.0",
"dependencies": {
"@myorg/pkg-a": "workspace:*"
}
}
Notes:
- workspaces can be an array of glob patterns (root manifest). [1]
- Use "workspace:*", "workspace:^", etc. to reference local workspace versions and keep resolution consistent. You can still run yarn workspaces foreach, yarn workspace , and use yarn workspaces focus to limit installs. [1][2][3]
References:
[1] Yarn manifest (package.json) — workspaces docs.
[2] Yarn workspaces feature page.
[3] Yarn protocols (workspace: protocol examples).
Move workspace configuration from .yarnrc.yml to package.json.
The workspaces key is not supported in .yarnrc.yml for Yarn 4.x. In Yarn v4, workspaces must be defined in the root package.json as an array. Move lines 3-6 to your root package.json:
{
"private": true,
"workspaces": [
"packages/*",
"crates/*"
]
}Then remove the workspace configuration from .yarnrc.yml.
🤖 Prompt for AI Agents
.yarnrc.yml around lines 3-6: the workspace configuration belongs in the root
package.json for Yarn v4, so remove the workspaces section from .yarnrc.yml and
add a "private": true and "workspaces": ["packages/*","crates/*"] entry to the
root package.json (as an array), ensuring the workspaces entries are moved
exactly and formatted as a JSON array under package.json, then save both files.
Summary by CodeRabbit
Chores
Release