Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regular email updates for project managers (fixes #1377) #1647

Closed
wants to merge 26 commits into from
Closed

Regular email updates for project managers (fixes #1377) #1647

wants to merge 26 commits into from

Conversation

fitoria
Copy link
Contributor

@fitoria fitoria commented May 29, 2019

No description provided.

fitoria and others added 5 commits May 10, 2019 11:55
@fitoria
Optimize gulp watch to only track files inside our project and not the
a812345 
whole node_modules dir, it uses less CPU this way.
@pantierra
Clean up deprecated windows devops script
205c656
@JorgeMartinezG
Include additional fields on tests
a6ffc4f
@nrotstan
Allow expert validators to classify mapping issues
7dbd98a 
> Note: this includes a new database migration

* Show validators in expert mode an additional form allowing them to
(optionally) classify the type and number of problems they discover with
mapping work that is leading to invalidation of the task

* Record identified mapping issues in a `task_mapping_issues` database
table

* Display noted mapping issues in the task history immediately below the
invalidation where they were recorded

* Allow mapping issues fixed by the validator on behalf of the mapper
to be noted when marking a task as validated

* Display in the task history when a task was validated with fixes, and
show the identified list of issues addressed by the validator

* Add a new page, accessible from the account-nav dropdown menu, on
which project managers and admins can manage the available mapping-issue
categories

* Seed the mapping-issue categories with a couple of initial categories

* Add server RESTful API endpoints for managing mapping-issue categories

* Add new `mapping_issue_categories` and `task_mapping_issues` database
tables in new migration

* Add support on server for optional inclusion of noted mapping issues
during task validation/invalidation
@pantierra
Remove What is New page
2d8bc55
@pantierra pantierra added this to the 3.4 Release milestone May 30, 2019
pantierra and others added 21 commits May 30, 2019 10:21
@pantierra
Merge pull request #1634 from hotosm/feature/remove-whats-new
c5efa77 
Remove "What is New" page
@pantierra
Merge pull request #1567 from hotosm/feature/clean-windowns-instructions
aa4d818 
Clean up deprecated windows devops script
@pantierra
Merge pull request #1566 from hotosm/bugfix/fix-gulp-watch
b73539c 
Optimize gulp watch
@ramyaragupathy @pantierra
Correct time calculations in user profile (#1571)
ddd7110 
Correct time calculations in user profile
@pantierra
Merge pull request #1276 from nrotstan/expert-mapping-issue-categoriz…
cc29040 
…ation

Allow expert validators to classify mapping issues
@geohacker @pantierra
Add Task Annotations
fbefbe3
@fitoria @pantierra
Update migration and fix minor default value issue
3fd7347
@pantierra
Merge pull request #1577 from hotosm/develop_tm4ml_backend
b83a849 
Add Task Annotations backend
@nrotstan @pantierra
Mapper-level icons and encouragement messages
b3409ca 
* Show a trophy icon in the top-nav in a color representing the
logged-in user's mapping level (bronze, silver, or gold for beginner,
intermediate, or advanced respectively), and also prominently display
user's mapping level on their profile page

* Show message on home page and profile page encouraging mappers to
continue mapping and advance to the next level (or to try validating in
the case of advanced mappers)
@pantierra
Merge pull request #1643 from hotosm/mapper-level-icon-and-encouragement
27254c7 
Mapper-level icons and encouragement messages
@nrotstan @pantierra
View changesets in OSMCha. Closes #1362
6016d0f 
* Add button to task's Advanced section for viewing a task's changesets
in OSMCha

* Add button for viewing project-wide changesets in OSMCha, visible to
users with validator or higher role (expert or higher for projects that
don't enforce a validator role)

* Add new column to projects for storing an OSMCha filter id that can be
optionally used to load a custom OSMCha filter in place of the standard
project-wide filters for projects that require a more customized set of
filters

* A project's OSMCha filter id can be managed from the Metadata section
when creating or editing a project
@pantierra
Merge pull request #1561 from hotosm/feature/1362-osmcha-integration
ae4ea0f 
View changesets in OSMCha. Closes #1362
@pantierra
Merge pull request #1581 from hotosm/fields_test
32f5975 
Include additional fields on tests
@arunasank
Use smaller RDS instances for non production stacks (#1657)
34d28d0 
* use cheaper rds instances for non production stacks

* configurable min/max
@nrotstan
Show expert users ISO8601 timestamps on hover
bc28885 
* Users in expert mode can hover over a timestamp to view it in IS08601
format

* Clicking the ISO8601 timestamp copies it to the user's clipboard

* Users who are not in expert mode continue to experience existing
behavior
@fitoria
Transfer project to new owner feature, fixes #1341
ad082ac
@fitoria @pantierra
Fix tasks annotations and complete with tasks details
3869f28
Merge pull request #1670 from hotosm/feature/fix-tasks-annotations
756e0a2 
Fix tasks annotations and add tasks details
Merge pull request #1663 from hotosm/feature/transfer-project-to-new-…
64caf71 
…onwer

Transfer project to new owner feature, fixes #1341
Merge pull request #1661 from hotosm/feature/1359-expert-iso8601-time…
96cfadc 
…stamps

Show expert users ISO8601 timestamps on hover
@fitoria @pantierra
Add weekly email for project managers
f13d089
@pantierra pantierra force-pushed the feature/1377-managers-mail-updates branch from ccd0152 to f13d089 Compare June 5, 2019 12:59
@pantierra
Copy link
Contributor

pantierra commented Jun 5, 2019 •
edited
Loading

Rebased and cleaned commits today.

I have some remarks on this, which i wrote in #1377 (comment). Basically to implement the surroundings that a user and admins needs to deal with such messages:

  • Settings page to opt out of all emails and a way opt-out per project.
  • Link in the email footer to the "email preferences".
  • Per default, disable (or send to log) automatic messages. An let opt-in on certain deployments, like live. We probably don't want to send emails to project managers from the staging or a local developers' machines imp

@pantierra pantierra changed the title Fixes #1377 managers mail updates Regular e-mail updates for project managers (fixes #1377) Jun 5, 2019
@pantierra pantierra changed the title Regular e-mail updates for project managers (fixes #1377) Regular email updates for project managers (fixes #1377) Jun 5, 2019
@pantierra pantierra modified the milestones: 3.4 Release, 4.0 Release Jun 25, 2019
@pantierra pantierra modified the milestones: 4.0 Release, 4.1 Release Dec 12, 2019
@willemarcel willemarcel modified the milestones: 4.1.0 Release, 4.2.0 Jul 17, 2020
@Aadesh-Baral
Copy link
Contributor

Reworked on #1935.

@Aadesh-Baral Aadesh-Baral deleted the feature/1377-managers-mail-updates branch July 13, 2022 07:39
@Aadesh-Baral Aadesh-Baral restored the feature/1377-managers-mail-updates branch July 31, 2022 08:14
@Aadesh-Baral Aadesh-Baral deleted the feature/1377-managers-mail-updates branch August 17, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority: medium status: in progress type: enhancement Improving an existing functionality
Projects
None yet
Milestone
v4.5.0
Development

Successfully merging this pull request may close these issues.
9 participants
@fitoria @pantierra @Aadesh-Baral @willemarcel @JorgeMartinezG @nrotstan @ramyaragupathy @geohacker @arunasank