Add support for tab encryption #3345
Merged
+3,936
−822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hluk
force-pushed
the
encrypt-tabs
branch
2 times, most recently
from
4e00865 to
41cd2e0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3345 +/- ##
==========================================
+ Coverage 79.90% 79.95% +0.05%
==========================================
Files 231 238 +7
Lines 28469 29671 +1202
==========================================
+ Hits 22747 23724 +977
- Misses 5722 5947 +225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hluk
force-pushed
the
encrypt-tabs
branch
18 times, most recently
from
5c20ca6 to
dcbedc3
Compare
hluk
force-pushed
the
encrypt-tabs
branch
8 times, most recently
from
4276913 to
b42f05e
Compare
hluk
force-pushed
the
encrypt-tabs
branch
4 times, most recently
from
0f19bb7 to
d2a49b7
Compare
hluk
force-pushed
the
encrypt-tabs
branch
14 times, most recently
from
d94a51e to
59baee8
Compare
Fixes the following Qt warning:
QObject::disconnect: wildcard call disconnects from destroyed signal
of ConfigurationManager::ConfigurationManager
Adds build dependencies for enabling the encryption: QCA, QtKeychain Removes the instructions for building with old unmaintained Qt 5 libraries. CopyQ may drop the support in the near future. Removes the source code building instructions from README file and adds just a link to the documentation.
This enables encrypting all tab data on disk that are not handled by plugins (i.e. Synchronization and Encryption which itself uses gpg) using single password. The feature is disabled by default, needs to be enabled in Preferences. Requires [QCA library](https://invent.kde.org/libraries/qca) and keyring support needs [QtKeychain](https://github.com/frankosterfeld/qtkeychain). This can be disabled by CMake options `WITH_QCA_ENCRYPTION` and `WITH_KEYCHAIN`. To check if encryption is supported by the app (from Action dialog or command line): copyq 'popup("Encryption", info("has-encryption") === "1" ? "Supported" : "NOT supported")' copyq 'popup("Keychain Access", info("has-keychain") === "1" ? "Supported" : "NOT supported")' To enable the feature from command line: copyq config tab_encryption_enabled true To disable storing password in external keyring: copyq config use_key_store false Encrypted files cannot be exported and imported in scripts - there is no support for passing passwords from scripts. Assisted-by: Claude Code Fixes #2617
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables encrypting all tab data on disk that are not handled by plugins (i.e. Synchronization and Encryption which itself uses gpg) using single password.
The feature is disabled by default, needs to be enabled in Preferences.
Requires QCA library and keyring support needs QtKeychain. This can be disabled by CMake options
WITH_QCA_ENCRYPTIONandWITH_KEYCHAIN.To check if encryption is supported by the app (from Action dialog or command line):
To enable the feature from command line:
To disable storing password in external keyring:
Encrypted files cannot be exported and imported in scripts - there is no support for passing passwords from scripts.
TODO:
Assisted-by: Claude Code
Fixes #2617