Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove pods; implement deployments/stateful sets #75

Merged
merged 23 commits into from
Oct 9, 2023

Conversation

MicaiahReid
Copy link
Contributor

@MicaiahReid MicaiahReid commented Sep 29, 2023

Description

Fixes #63

Breaking change?

Example


Checklist

  • All tests pass
  • Tests added in this PR (if applicable)

@MicaiahReid MicaiahReid changed the title Remove pods feat: remove pods; implement deployments/stateful sets Sep 29, 2023
@MicaiahReid MicaiahReid marked this pull request as ready for review September 29, 2023 16:05
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #75 (9190724) into develop (5d8c5b1) will increase coverage by 1.13%.
The diff coverage is 89.80%.

@@             Coverage Diff             @@
##           develop      #75      +/-   ##
===========================================
+ Coverage    79.64%   80.77%   +1.13%     
===========================================
  Files           11       13       +2     
  Lines         1076     1233     +157     
===========================================
+ Hits           857      996     +139     
- Misses         219      237      +18     
Files Coverage Δ
src/config.rs 85.56% <100.00%> (+5.17%) ⬆️
src/main.rs 93.47% <100.00%> (ø)
src/resources/deployment.rs 100.00% <100.00%> (ø)
src/resources/pvc.rs 100.00% <100.00%> (ø)
src/resources/stateful_set.rs 100.00% <100.00%> (ø)
src/routes.rs 80.39% <100.00%> (+0.19%) ⬆️
src/template_parser.rs 100.00% <100.00%> (ø)
src/lib.rs 77.84% <89.02%> (+1.64%) ⬆️

@MicaiahReid MicaiahReid temporarily deployed to Development October 3, 2023 19:43 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid temporarily deployed to Staging October 3, 2023 19:53 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid temporarily deployed to Development October 4, 2023 14:49 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid temporarily deployed to Staging October 4, 2023 14:52 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid temporarily deployed to Development October 4, 2023 17:19 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid temporarily deployed to Development October 4, 2023 18:23 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid temporarily deployed to Staging October 4, 2023 19:07 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid requested a review from CharlieC3 October 4, 2023 20:20
@MicaiahReid MicaiahReid temporarily deployed to Development October 4, 2023 20:48 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid temporarily deployed to Staging October 4, 2023 21:03 — with GitHub Actions Inactive
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job on this! 🚀 From what I can tell, this comprehensively addresses #63. I left a few comments/questions which, considering you tested this out and verified it works as-is, should not block this from getting merged. If you choose to make any changes based on my comments and I'm unable to re-approve, I think you should be good to merge anyways if you verify it still works as expected.

@MicaiahReid MicaiahReid temporarily deployed to Development October 9, 2023 04:31 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid temporarily deployed to Staging October 9, 2023 13:32 — with GitHub Actions Inactive
@MicaiahReid MicaiahReid merged commit 6399c19 into develop Oct 9, 2023
10 checks passed
@MicaiahReid MicaiahReid deleted the remove-pods branch October 9, 2023 13:41
blockstack-devops pushed a commit that referenced this pull request Mar 25, 2024
## [1.1.0](v1.0.0...v1.1.0) (2024-03-25)

### Features

* allow config path to be configured via env var ([#67](#67)) ([483fb8b](483fb8b))
* allow configuring k8s context with env var ([#71](#71)) ([f7e6bc3](f7e6bc3))
* check auth header before allowing access ([#47](#47)) ([6dcb36d](6dcb36d))
* remove pods; implement deployments/stateful sets ([#75](#75)) ([6399c19](6399c19))
* status page at `GET /` and `GET /api/v1/status` routes ([#68](#68)) ([d4c2290](d4c2290))
* upgrade clarinet to v2.4.0; enable `use_nakamoto` field to configure stacks chain for nakamoto ([#89](#89)) ([521acd1](521acd1))
* upgrade to using clarinet crate to parse config  ([#46](#46)) ([d57d3a1](d57d3a1))

### Bug Fixes

* add ACCESS_CONTROL_ALLOW_HEADERS to response header ([#52](#52)) ([225d2c9](225d2c9))
* add subPath for postgres volume mount ([#73](#73)) ([7812741](7812741))
* api container spelling fix ([7b52f93](7b52f93))
* don't require auth on OPTIONS requests; configure user-id prefix to make namespace ([#51](#51)) ([9fe7972](9fe7972))
* reduce permissions for cluster role ([#54](#54)) ([2ea50ea](2ea50ea))
* removing untemplated labels ([#82](#82)) ([e92dcb5](e92dcb5))
* set img pull policy for stacks blockchain api ([0b959c2](0b959c2))
* template ([#85](#85)) ([4399177](4399177))
@blockstack-devops
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update Pods to appropriate workload spec
3 participants